Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No braille feedback in Excel when editing directly in cell #9749

Closed
dkager opened this issue Jun 15, 2019 · 13 comments · Fixed by #9660
Closed

No braille feedback in Excel when editing directly in cell #9749

dkager opened this issue Jun 15, 2019 · 13 comments · Fixed by #9660

Comments

@dkager
Copy link
Collaborator

@dkager dkager commented Jun 15, 2019

Steps to reproduce:

  1. Open Excel 2016 (Office 365) and make sure "Allow editing directly in cells" is turned on in File --> Options --> Advanced.
  2. Start typing.

Actual behavior:

You receive speech output, but no feedback in braille.

Expected behavior:

You receive both speech and braille feedback as you type.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2019.1.1

Windows version:

Windows 10 (1809)

Name and version of other software in use when reproducing the issue:

Excel 2016 32-bit (latest from Office 365 as of today)

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes, seen to be working in NVDA 2019.1.

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jun 15, 2019

@dkager
Copy link
Collaborator Author

@dkager dkager commented Jun 15, 2019

Yes, it looks like a regression in the minor release, but with Office 365 changing nearly every week I don't want to make that claim too firm.

The braille display continues to show the cell number, e.g. A1.

The focus object seems to be OK:

name: u'Edit Cell'
role: ROLE_EDITABLETEXT
states: STATE_FOCUSABLE, STATE_FOCUSED
isFocusable: True
hasFocus: True

When I start editing a cell and Alt+Tab away and then back into Excel the braille display shows the entered text, but any additional text you enter does not show up until you Alt+Tab again. Using Backspace will update the braille display, but typing characters does not.

@bramd
Copy link
Contributor

@bramd bramd commented Jun 15, 2019

Confirmed here. If you toggle braille tethering to review and back to focus or automatic again, it shows the correct output.

@MarcoZehe
Copy link
Contributor

@MarcoZehe MarcoZehe commented Jun 16, 2019

Could this be a symptom of this long-standing issue that braille simply doesn't track properly when typing in Windows 10 Mail, sometimes Outlook, or any other UIA-enabled app, only if you move the caret with arrow keys, does it catch up? I am seeing this kind of behavior all over the place when using braille. You type a hundred or so characters, and braille just doesn't show them unless I press an arrow key once.

@dkager
Copy link
Collaborator Author

@dkager dkager commented Jun 16, 2019

Good point. I see this in other Windows 10 apps too, such as Calendar.
@leonardder Do we use UIA for the Excel edit fields?

@dkager
Copy link
Collaborator Author

@dkager dkager commented Jun 16, 2019

Here is the developer information for the edit field. Looks like it is UIA.

name: u'Edit Cell'
role: ROLE_EDITABLETEXT
states: STATE_FOCUSABLE, STATE_FOCUSED
isFocusable: True
hasFocus: True
Python object: <NVDAObjects.Dynamic_EditableTextWithoutAutoSelectDetectionUIA object at 0x05958C70>
Python class mro: (<class 'NVDAObjects.Dynamic_EditableTextWithoutAutoSelectDetectionUIA'>, <class 'NVDAObjects.behaviors.EditableTextWithoutAutoSelectDetection'>, <class 'editableText.EditableTextWithoutAutoSelectDetection'>, <class 'NVDAObjects.behaviors.EditableText'>, <class 'editableText.EditableText'>, <class 'NVDAObjects.UIA.UIA'>, <class 'NVDAObjects.window.Window'>, <class 'NVDAObjects.NVDAObject'>, <class 'documentBase.TextContainerObject'>, <class 'baseObject.ScriptableObject'>, <class 'baseObject.AutoPropertyObject'>, <type 'object'>)
description: ''
location: RectLTWH(left=40, top=331, width=96, height=29)
value: None
appModule: <'excel' (appName u'excel', process ID 1100) at address 580a630>
appModule.productName: u'Microsoft Office'
appModule.productVersion: u'16.0.11629.20246'
TextInfo: <class 'NVDAObjects.UIA.UIATextInfo'>
windowHandle: 198768
windowClassName: u'EXCEL7'
windowControlID: 0
windowStyle: 1460338688
windowThreadID: 7180
windowText: u'Book1'
displayText: u''
UIAElement: <POINTER(IUIAutomationElement) ptr=0x7f239d0 at 54e8940>
UIA automationID: CellEdit
UIA frameworkID: 
UIA runtimeID: (42, 198768, 4, 494)
UIA providerDescription: [pid:1100,providerId:0x0 Main(parent link):Unidentified Provider (unmanaged:mso.dll)]
UIA className: 
UIA patterns available: LegacyIAccessiblePattern, TextPattern

@MarcoZehe
Copy link
Contributor

@MarcoZehe MarcoZehe commented Jun 16, 2019

@dkager
Copy link
Collaborator Author

@dkager dkager commented Jul 7, 2019

Coming back to the suggestion that the problem is related to braille and UIA edit fields: I'm seeing similar prolems in OneNote (both desktop and Windows 10 app), Microsoft Edge and several other programs. So the behavior in Excel appears to be an example of a larger problem, as Marco said. Should we use one GitHub issue to track these problems?

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Jul 7, 2019

If there are different cases with similar steps to reproduce and the cause seems to be the same, I suggest to create a meta issue for such problems.

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jul 8, 2019

@dkager: DO you also see these Edge issues in 2019.1 or older?

Pretty sure that all these cases are fixed by #9660. WHen running NVDA with that patch applied, the problems are gone.

@dkager
Copy link
Collaborator Author

@dkager dkager commented Jul 8, 2019

Interesting. Will that patch make 2019.2? My tests thus far were with 2019.1 and 2019.1.1.

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Sep 10, 2019
@Sylvie42
Copy link

@Sylvie42 Sylvie42 commented Oct 26, 2020

Hello,
Using NVDA 2020.3 and Office 365 for businesses version Microsoft Office 16.0.13231.20390
I have Windows 10 version Windows 1909 (version 18363.139)
When the checkbox on direct editing is checked, I have no feedback in Braille about what I am typing. The same while typing F2 to modifiy the cell.
When the checkbox is unchecked, everything is oK.
After contacting Microsoft, they answered I should contact NV Access for this bug.
Best
Sylvie

@aaclause
Copy link
Contributor

@aaclause aaclause commented Oct 26, 2020

Same here (Office Professional Plus 2019 16.0.13231.20390). The bug also occurs with NVDA 2020.1 and 2020.2.
Temporary solution: after entering in edit mode, move to focus object (NVDA+backspace [laptop] or NVDA+numpadMinus [desktop]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants