Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Console: Preserve the result of the last executed command #9782

Closed
JulienCochuyt opened this issue Jun 21, 2019 · 0 comments · Fixed by #9783
Closed

Python Console: Preserve the result of the last executed command #9782

JulienCochuyt opened this issue Jun 21, 2019 · 0 comments · Fixed by #9783
Milestone
2019.3

Comments

@JulienCochuyt
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The NVDA Python Console implementation prevents clobbering of the gettext _ built-in but at the same time prevents the user from taking advantage of the standard sys.displayhook saving the last returned value under that same name.

Describe the solution you'd like

Best of both worlds: Gettext not clobbered and last returned value accessible as the underscore variable.

Describe alternatives you've considered

Additional context

Upcoming PR
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Jun 21, 2019
@JulienCochuyt
Python Console: Preserve the result of the last executed command (nva…
8b203fc 
…ccess#9782)
@JulienCochuyt JulienCochuyt mentioned this issue Jun 21, 2019
Merged
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Jun 21, 2019
@JulienCochuyt
Python Console: Preserve the result of the last executed command (nva…
3ad3df3 
…ccess#9782)

Update Developer Guide
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jun 25, 2019
michaelDCurran pushed a commit that referenced this issue Jun 25, 2019
@JulienCochuyt @michaelDCurran
Python Console: Preserve the result of the last executed command (#9782…
329657f 
…) (#9783)

* Python Console: Preserve the result of the last executed command (#9782)

* Python Console: Preserve the result of the last executed command (#9782)

Update Developer Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2019.3
Development

Successfully merging a pull request may close this issue.

Python Console: Preserve the result of the last executed command (#9782) accessolutions/nvda
2 participants
@nvaccessAuto @JulienCochuyt