Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpha updates and lint error reporting #10020

Merged
merged 5 commits into from Aug 2, 2019

Conversation

@feerrenrut
Copy link
Contributor

commented Aug 2, 2019

Link to issue number:

Summary of the issue:

  • Alpha users are unable to update
    • The new method of uploading artifacts does so with out preserving the folder structure
    • The URL for updates expects the executable to live at output/nvda....exe
  • Some lint test failures are not being reported

Description of how this pull request fixes the issue:

  • Use a structure preserving mechanism to upload artifacts
  • Read PR-Flake8.txt as ANSI, ignore errors.

Testing performed:

  • Wait for build to complete, see if artifact URL is as required.
  • Locally converted the Flake8.txt file from the example failed build using the createJunitReport.py script

Known issues with pull request:

Change log entry:

Section: New features, Changes, Bug fixes

feerrenrut added some commits Aug 2, 2019

Fix NVDA exe upload location
When the artifacts are uploaded, they need to preserve the folder structure.
Despite a folder structure, all atrifacts are listed on the appveyor build
result page in a flat way.
Fix failure to upload lint errors to unit test results
Decoding as UTF-8 was not working for lint output, use ANSI
and replace on error instead.

@feerrenrut feerrenrut requested a review from leonardder Aug 2, 2019

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Aug 2, 2019

@feerrenrut

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

I copied the powershell code for uploading the artifacts from an appveyor example, it turns out it was quite broken. I think I have fixed it.

@AppVeyorBot

This comment has been minimized.

Copy link

commented Aug 2, 2019

Build execution time has reached the maximum allowed time for your plan (60 minutes). 😲

See test results for Failed build of commit 9f5febe045

@feerrenrut

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

oops, looks like this tried to upload the whole repo 😨

@feerrenrut feerrenrut merged commit 7b5cd2d into master Aug 2, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.