Improve presentation of graphical view table in disk management

[lukaszgo1]

Link to issue number:

None

Summary of the issue:

#9118 introduced support for graphical view of partition in Windows disk management. While it worked well for the most part UX could be better in some places namely:

1. Role of the partitions and disk was either table cell or table row header.
2. 'selected' was announced with every object.
3. When braille display was used and guessing of object position was enabled the reported positions were insane such as 65537 of 12.
4. Tool tips appearing when mouse was moved to one of these objects were reported as empty. Additionally when last object of the table was reached and mouse was positioned on one of the partitions empty tooltipp was announced over and over with each arrow press.

Description of how this pull request fixes the issue:

1. Now these controls are reclassed to list item, which in addition to giving more user-friendly role suppresses announcement of selected.
2. Reporting of position info is disabled for the graphical view table- see known issues below.
3. Display mode is used to retrieve text of tooltips and repeated one are filtered out.

Testing performed:

On Windows 7 and Windows 10 1903:

1. Moved to the table with TAB, made sure that selected isn't announced when navigating and role is list item.
2. With guessing of position info enabled and disabled ensured that there is no difference in output with both speech and braille.
3. With reporting of tooltips enabled ensured that they are reported and the repeated one are filtered out.

Known issues with pull request:

• For some tool tips show event never fires. I have no idea why and honestly don't think that it is particularly important.
• I've disabled reporting of position info because I have no idea how to reasonably present current position in the four directional and irregular table such as this one. It should be however possible to calculate correct values to some extend, because while the coordinates given were incorrect, they were incorrect in a regular way.

Change log entry:

Section: changes

• Presentation of graphical view table in disk management has been improved.

[lukaszgo1]

@codeofdusk You may be interested in taking a look at this.

[lukaszgo1]

@leonardder All done.

[lukaszgo1]

@leonardder This is ready for another review when you have time.
edit: Closed by mistake.

[lukaszgo1]

@leonardder You have a pending review here.

[codeofdusk]

Looks okay to me.

[feerrenrut]

This looks fine to me, I'll target this to 2020.4.

[feerrenrut]

Please could you make a suggestion for a change log entry (or several). Despite this being a cosmetic change, it is helpful for people to know it has been improved, and for testers to know what to focus on.

[lukaszgo1]

Hi @feerrenrut . Assuming that you're happy with these changes could you please merge this? I certainly don't want to rash you, but given for how long this has been open it'd be a pity to miss 2020.4 for this one.

[dpy013]

Are there any known problems with current PR?
I hope to see this PR in NVDA2020.4.

[feerrenrut]

Thanks @lukaszgo1

All review actions addressed