Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation in Windows Console: Always use ConsoleUIATextInfo in UIA consoles #10052

Merged
merged 4 commits into from Aug 13, 2019

Conversation

@codeofdusk
Copy link
Collaborator

commented Aug 8, 2019

Link to issue number:

Fixes #10030. Related to #9614.

Summary of the issue:

NVDA incorrectly reports an empty selection when focusing Windows consoles.

Since the TextInfo property on consoles was prefixed with an underscore, NVDA dynamically selected the wrong TextInfo implementation (see NVDAObjects.UIA.UIA._getTextInfo). This means that when a console is first focused, UIATextInfo is selected instead of WinConsoleUIA.TextInfo, so our patched isCollapsed logic isn't used and speech.speakPreselectedText is called (see lines 391–393 in speech/__init__.py).

Description of how this pull request fixes the issue:

Assign the textInfo class as WinConsoleUIA.TextInfo rather than WinConsoleUIA._TextInfo.

Testing performed:

Tested steps from the issue and confirmed that no superfluous selections are reported.

Known issues with pull request:

None.

Change log entry:

None.

@codeofdusk

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@leonardder leonardder requested a review from feerrenrut Aug 8, 2019

source/NVDAObjects/UIA/winConsoleUIA.py Outdated Show resolved Hide resolved

codeofdusk and others added some commits Aug 12, 2019

Update source/NVDAObjects/UIA/winConsoleUIA.py
Co-Authored-By: Reef Turner <feerrenrut@users.noreply.github.com>
@AppVeyorBot

This comment has been minimized.

Copy link

commented Aug 13, 2019

PR introduces Flake8 errors 😲

See test results for Failed build of commit d7784c33fc

@feerrenrut feerrenrut merged commit 26485a0 into nvaccess:master Aug 13, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.