Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bounding rectangle support for java text ranges #10157

Merged
merged 2 commits into from Sep 3, 2019

Conversation

leonardder
Copy link
Collaborator

@leonardder leonardder commented Aug 29, 2019

Link to issue number:

None

Summary of the issue:

Java text ranges expose a rectangle for every offset in a text range. We currently don't use this information.

Description of how this pull request fixes the issue:

Implement _getBoundingRectFromOffset on JABTextInfo.
As a bonus, this pr also adds an info log message when the java access bridge was succesfully initialized.

Testing performed:

Tested in the about java dialog that using move mouse to navigator object properly positions the mouse at the position of the selected unit.

Known issues with pull request:

None

Change log entry:

  • New features
    • The accuracy of the move mouse to navigator object command has been improved in text fields in Java applications.

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Aug 29, 2019

PR introduces Flake8 errors 😲

See test results for Failed build of commit 8b5645adde

@michaelDCurran michaelDCurran merged commit 3fb8d54 into nvaccess:master Sep 3, 2019
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Sep 3, 2019
@leonardder leonardder added the BabbageWork label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BabbageWork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants