Implement bounding rectangle support for java text ranges #10157
+56
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR introduces Flake8 errors See test results for Failed build of commit 8b5645adde |
michaelDCurran
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Link to issue number:
None
Summary of the issue:
Java text ranges expose a rectangle for every offset in a text range. We currently don't use this information.
Description of how this pull request fixes the issue:
Implement _getBoundingRectFromOffset on JABTextInfo.
As a bonus, this pr also adds an info log message when the java access bridge was succesfully initialized.
Testing performed:
Tested in the about java dialog that using move mouse to navigator object properly positions the mouse at the position of the selected unit.
Known issues with pull request:
None
Change log entry: