Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report hidden formatting in MS Word #10313

Merged
merged 3 commits into from Oct 7, 2019

Conversation

@CyrilleB79
Copy link
Contributor

commented Oct 2, 2019

Link to issue number:

Fixes #8713

Summary of the issue:

Hidden font formatting is not reported in MS Word (when nonprinting characters are displayed)

Description of how this pull request fixes the issue:

Get the hidden attribute of character at the cursor as done for italic or bold for example.

Testing performed:

Tested under Word 2016 and Outlook 2016 message with nonprinting characters displayed:

  • put the cursor in hidden text and press NVDA+F one or two times: hidden is reported correctly
  • put the cursor in non hidden text (normal) and press NVDA+F one or two times: hidden is not reported as expected
  • with font attributes reporting enabled, move the cursor with left/right arrow keys into or out of hidden text: "hidden" and "no hidden" is reported when expected

Known issues with pull request:

None

Change log entry:

Changes
Hidden font formatting is now reported in Microsoft Word. (#8713)

@AppVeyorBot

This comment has been minimized.

Copy link

commented Oct 2, 2019

PR introduces Flake8 errors 😲

See test results for Failed build of commit f3aaa9c087

source/speech/__init__.py Outdated Show resolved Hide resolved
@CyrilleB79

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Flake8 fails with the following message:

source/speech/init.py:1579:5: ET128 (flake8-tabs) unexpected number of tabs and spaces at start of expression line (expected 3 tabs and 8 spaces, got 4 tabs and 0 spaces)

Why does Flake8 say that it expects mixed tabs and spaces (3 tabs and 8 spaces) ?

@feerrenrut any thought? Thanks.

Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
@CyrilleB79

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

@leonardder thanks for suggestion. You are right actually, it is "no bold" or "no italic", but "not underlined", i.e. "not" with a verb in past participle.

@AppVeyorBot

This comment has been minimized.

Copy link

commented Oct 3, 2019

PR introduces Flake8 errors 😲

See test results for Failed build of commit 128b074015

@CyrilleB79

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Linting issue fixed.
Sorry to have disturbed.
The Flake8 message was not explicit at all but this behavior was already described in NVDA's linting process description.
The message deals with spaces and tabs but actually regards "hanging indent" style.

@michaelDCurran michaelDCurran merged commit a157fbd into nvaccess:master Oct 7, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Oct 7, 2019
michaelDCurran added a commit that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.