Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect the http link referenced by most readme files to https #10315

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@dingpengyu
Copy link
Contributor

commented Oct 3, 2019

Link to issue number:

#10314

Summary of the issue:

Most of the links introduced by the current NVDA readme.md are still http

Description of how this pull request fixes the issue:

Redirect most http links introduced by readme.md to https

Testing performed:

Tested using clone's NVDA codebase

Known issues with pull request:

Redirect the http link referenced by most readme files to https

Change log entry:

Redirect the http link referenced by most readme files to https #10314
Section: Bug fixes ,Changes
thanks

dingpengyu added 2 commits Oct 3, 2019
Copy link
Contributor

left a comment

Thanks, this looks good. Though can you confirm you have tested all these links work? Please let me know, then I'll merge.

@dingpengyu

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Thanks, this looks good. Though can you confirm you have tested all these links work? Please let me know, then I'll merge.

hi feerrenrut
Thanks for your review readme no problem

@feerrenrut feerrenrut merged commit 6cdb7be into nvaccess:master Oct 4, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.