Add appModule for Spring Tool Suite 4

[lukaszgo1]

Link to issue number:

Fixes #10001

Summary of the issue:

Spring Tool Suite 4 changed name of its main executable. Because of this proper appModule wasn't loaded.

Description of how this pull request fixes the issue:

Add app Module for a proper executable. This simply imports module for Eclipse.

Testing performed:

Try build tested by @alexandretoco. He confirms that proper module is loaded. I cannot test myself because Spring Tool suite fails to start on my machine for some reason.

Known issues with pull request:

None known

Change log entry:

Section: Bug fixes

Spring Tool Suite Version 4 is now supported

[AppVeyorBot]

PR introduces Flake8 errors 😲

See test results for Failed build of commit 1566466dff

[lukaszgo1]

This PR causes two Flake8 errors: F403 and F401. Can I simply ignore these with an appropriate noqa? All app modules importing module for different program are doing exactly the same. cc @feerrenrut

[lukaszgo1]

@alexandretoco Could you please download this build, temporarily remove module that I've send you privately from the scratchpad directory and confirt that the issue is fixed?

[alexandretoco]

Hi Lukasz! I can confirm that the snapshot corrected the problem in eclipse. How ever, I came back to the 2019.2.1 because I use eloquence and the snapshot didn’t recognize it. Enviado do Email para Windows 10 De: Łukasz Golonka Enviado:domingo, 6 de outubro de 2019 16:45 Para: nvaccess/nvda Cc:alexandretoco; Mention Assunto: Re: [nvaccess/nvda] Add appModule for Spring Tool Suite 4 (#10339) @alexandretoco Could you please download this build, temporarily remove module that I've send you privately from the scratchpad directory and confirt that the issue is fixed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[lukaszgo1]

The add-on that you ate using is not compatible with Python 3, so this isn't caused by this PR.

[feerrenrut]

Can I simply ignore these with an appropriate noqa?

In most cases, despite it breaking consistency, I would prefer just what is used be imported explicitly. In this case, because the goal is to map a new executable name to the same app module without having to maintain another file then I agree import * is the least brittle way. However please make sure you add a comment to explain why this #noqa is an exception.

I would really like app modules to be mapped via a more flexible mechanism than by matching the python file name with the executable.

[lukaszgo1]

@feerrenrut Done, I hope my commend is clear enough. I'd be nice to have this merged in time for 2019.3 because without this fix latest version of Spring Tool isn't really usable according to @alexandretoco

[leonardder]

@feerrenrut wrote:

I would really like app modules to be mapped via a more flexible mechanism than by matching the python file name with the executable.

see #10248, which is related to that desire.

[lukaszgo1]

@leonardder You have pending review here.

[lukaszgo1]

@feerrenrut This is ready for a review if you have time.

[lukaszgo1]

@feerrenrut Would you be able to review this, and if it looks ok get it into 2019.3? I understand that we are quite close to the release, however the change itself is very small and without it someone depending on latest version of Spring Tool has to wait a few more months.

[feerrenrut]

Thanks @lukaszgo1