Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add appModule for Spring Tool Suite 4 #10339
Link to issue number:
Summary of the issue:
Spring Tool Suite 4 changed name of its main executable. Because of this proper appModule wasn't loaded.
Description of how this pull request fixes the issue:
Add app Module for a proper executable. This simply imports module for Eclipse.
Try build tested by @alexandretoco. He confirms that proper module is loaded. I cannot test myself because Spring Tool suite fails to start on my machine for some reason.
Known issues with pull request:
Change log entry:
Section: Bug fixes
Spring Tool Suite Version 4 is now supported
Hi Lukasz! I can confirm that the snapshot corrected the problem in eclipse. How ever, I came back to the 2019.2.1 because I use eloquence and the snapshot didn’t recognize it. Enviado do Email para Windows 10 De: Łukasz Golonka Enviado:domingo, 6 de outubro de 2019 16:45 Para: nvaccess/nvda Cc:alexandretoco; Mention Assunto: Re: [nvaccess/nvda] Add appModule for Spring Tool Suite 4 (#10339) @alexandretoco Could you please download this build, temporarily remove module that I've send you privately from the scratchpad directory and confirt that the issue is fixed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
In most cases, despite it breaking consistency, I would prefer just what is used be imported explicitly. In this case, because the goal is to map a new executable name to the same app module without having to maintain another file then I agree
I would really like app modules to be mapped via a more flexible mechanism than by matching the python file name with the executable.
@feerrenrut Would you be able to review this, and if it looks ok get it into 2019.3? I understand that we are quite close to the release, however the change itself is very small and without it someone depending on latest version of Spring Tool has to wait a few more months.