Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Universal CRT libraries when creating NVDA distribution #10347

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@lukaszgo1
Copy link
Contributor

commented Oct 7, 2019

Link to issue number:

Fixes #10031

Summary of the issue:

After migration to Python 3 it was no longer possible to start NVDA under anything older than Windows 10 as long as update containing Universal CRT was not installed.

Description of how this pull request fixes the issue:

During scons dist all Universal CRT libraries are copied from Windows 10 SDk to the dist folder.

Testing performed:

TBD. When investigating #10031 I've copied exactly the same set of DLLs manually to the NVDA folder and it fixed the problem, so I am quite confident about this fix.

Known issues with pull request:

  1. I've chosen to detect Windows 10 SDK path using the registry rather than hard coding it. I hope this would account for situations in which it is installed to some custom location, but I haven't tested this.
  2. Building on 32-bit wasn't tested with this fix. It is not a big deal because building under 32-bit Windows is currently broken (see #9990). I'll test this as soon as we update to VS 2019. This shouldn't block this pr.
  3. I am not entirely happy with the code. My SCons knowledge is very limited, so it probably could be accomplished in a more elegant way.

Change log entry:

None needed as this fixes regression not yet in a release.

This makes it again possible to use NVDA on clean installs of Windows versions older than Windows 10.
Fixes #10031
@lukaszgo1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

cc @feerrenrut @leonardder @michaelDCurran could one of you review this when the time permits? It is very important to get this into 2019.3.

@michaelDCurran michaelDCurran merged commit b40bc9e into nvaccess:master Oct 7, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Oct 7, 2019
@lukaszgo1 lukaszgo1 deleted the lukaszgo1:I10031 branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.