Add textInfos unit mappings for UIA document, page and format field, make FORMATFIELD and CONTROLFIELD units global #10396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The _UIAHandler.NVDAUnitsToUIAUnits mapping is incomplete, not containing document and page.
Description of how this pull request fixes the issue:
I added these units. I also discovered that we have TextUNitFormat, which is equivalent to NVDA format fields. Therefore, I moved the UNIT_CONTROLFIELD and UNIT_FORMATFIELD units from VirtualBufferTextINfo to the textInfos package. This should make the code more consistent and also fixes a theoretical bug where BrowseModeDocumentTreeInterceptor.event_caretMovementFailed tried to use UNIT_CONTROLFIELD on a TextInfo that didn't have this constant.
Testing performed:
Tested that in Word with UIA enabled, I can expand to page, story and format field.
Known issues with pull request:
None
Change log entry: