Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide NVDA store app with UIAccess capabilities #10464

Merged
merged 5 commits into from Nov 6, 2019

Conversation

@michaelDCurran
Copy link
Contributor

michaelDCurran commented Nov 5, 2019

Link to issue number:

None

Summary of the issue:

So far, NvDA packaged as a Windows Store app (whether side-loaded or instaled from the Store itself) has not been able to provide audio ducking, touch interaction, or access to elevated apps.
However, in recent Windows insider builds, it has no become possible to request the UIAccess privilege from a Desktop Bridge packaged store app.

Description of how this pull request fixes the issue:

NVDA now packages nvda_uiAccess.exe rather than nvda_noUIAccess.exe in the appx package, and also requests the UIAccess privilege in its appx package manifest.
It also removes a couple of hard limits, for instance it no longer refuses to initialize touch interaction and audio ducking if running as an appx package.
This PR also requests the auto startup capability, which means that once you run NVDA store version once, it will continue to automatically run at start-up. To toggle this on and off, use the start-up tab in task Manager.

Testing performed:

Installed side-loaded, and installed via a private Store submission URL, NVDA is now abile to provide touch interaction, audio ducking, and can interact with elevated apps such as Regedit.

Known issues with pull request:

  • As the UIAccess privilege is only available in Windows Insider build 18990 and higher, this is now the minimum version this appx package can be installed on.
  • Although a UAC prompt will be shown when installing directly from the store, this does not occur by default when side-loading and therefore a normal side-load install will fail. To install side-loaded now, you need to open a Powershell console as administrator and install the package using add-appxpackage. It is hoped that Windows will add capabilities to the side-load install mechanism to automatically elevate when installing in order to gain the UIAccess capability.

Change log entry:

None yet - NVDA in the store is still not officialy supported.

@michaelDCurran michaelDCurran requested a review from feerrenrut Nov 5, 2019
@michaelDCurran michaelDCurran changed the title Appx with ui access Provide NVDA store app with UIAccess capabilities Nov 5, 2019
@feerrenrut

This comment has been minimized.

Copy link
Contributor

feerrenrut commented Nov 5, 2019

As the UIAccess privilege is only available in Windows Insider build 18990 and higher, this is now the minimum version this appx package can be installed on.

I assume this is something we will need communicate on releases? Have you got a plan for how to do that?

@feerrenrut

This comment has been minimized.

Copy link
Contributor

feerrenrut commented Nov 5, 2019

Although, I guess the windows store handles compatibility when installed that way, and sideloading appx is not published for our main releases. So perhaps not?

@michaelDCurran michaelDCurran merged commit 8cd9582 into master Nov 6, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Nov 6, 2019
@michaelDCurran

This comment has been minimized.

Copy link
Contributor Author

michaelDCurran commented Nov 6, 2019

Yes, we don't advertise the app in the store nor the side-loaded version, which in fact is only available directly from appveyor. we do not even have infrastructure to publish the files anywhere for actual releases or auto submission to the store etc. We just keep the code to ensure that we continue to build fine at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.