Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getBrailleTextForProperties to getPropertiesBraille #10469

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@leonardder
Copy link
Collaborator

leonardder commented Nov 6, 2019

Link to issue number:

Mentioned in #10371

Summary of the issue:

In #10371, getSpeechTextForProperties was renamed to getPropertiesSpeech.

Description of how this pull request fixes the issue:

Do the same for braille: getBrailleTextForProperties > getPropertiesBraille

I noticed that in the eclipse module, the position kwarg was passed to it. This is wrong, I fixed this to be positionInfo.

Testing performed:

Made sure that NVDA and braille still works.

Known issues with pull request:

NOne

Change log entry:

  • Changes for developers
    • The braille function getBrailleTextForProperties has been renamed to getPropertiesBraille.
@leonardder leonardder requested a review from feerrenrut Nov 6, 2019
Copy link
Contributor

feerrenrut left a comment

Thanks @leonardder

@feerrenrut feerrenrut merged commit 46fc5eb into nvaccess:master Nov 6, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Nov 6, 2019
feerrenrut added a commit that referenced this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.