Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store speech priorities in an enum #10471

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@leonardder
Copy link
Collaborator

leonardder commented Nov 6, 2019

Link to issue number:

Briefly discussed in #10371

Summary of the issue:

Speech refactor introduced speech priorities, which were constants.

Description of how this pull request fixes the issue:

As Python 3 has an Enum type and this code is new to the Python 3 version of NVDA, use an enum instead.

This allso adds some type hints to speech functions.

Testing performed:

Tested running from source. Tested that speech priorities still work, i.e. that higher prio speech interrupts lower prio speech.

Known issues with pull request:

None

Change log entry:

None needed.

@leonardder leonardder added this to the 2019.3 milestone Nov 6, 2019
@leonardder leonardder requested a review from feerrenrut Nov 6, 2019
@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 6, 2019

PR introduces Flake8 errors 😲

See test results for Failed build of commit beef8e0afa

@feerrenrut

This comment has been minimized.

Copy link
Contributor

feerrenrut commented Nov 7, 2019

It is probably worth adding a clear note in the description of this PR to addon developers and posting in the mailing lists about this change.

Copy link
Contributor

feerrenrut left a comment

Thanks @leonardder

source/speech/priorities.py Show resolved Hide resolved
Copy link
Contributor

feerrenrut left a comment

Ok, thanks @leonardder

@feerrenrut feerrenrut merged commit 0124e64 into nvaccess:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.