Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run initial display for braille on the main thread #10498

Merged
merged 2 commits into from Nov 18, 2019

Conversation

@leonardder
Copy link
Collaborator

leonardder commented Nov 18, 2019

Link to issue number:

fixes #9982

Summary of the issue:

If the braille display auto-detection feature is enabled and large braille table(s) (> 1 MB) are loaded on NVDA startup, the braille table(s) couldn't be completely loaded respectively compiled. Sometimes also the include opcode no longer operates and the braille output keeps blank after NVDA startup unless the braille output was updated (e.g. by opening the NVDA menu). Or only parts of the braille tables are loaded. A "Can't translate" runtime Error was logged on startup.
This issue was confirmed by @DrSooom.

The likely cause for this is that with auto detection, liblouis translation is executed from the background detection thread, rather than the main thread.

Description of how this pull request fixes the issue:

Queue initial displaying to the main thread.

Testing performed:

Tests by @DrSooom in a try build.

Known issues with pull request:

None known

Change log entry:

  • Bug fixes
    • Some rare braille translation issues and errors with liblouis have been resolved. (#9982)
Leonard de Ruijter added 2 commits Sep 27, 2019
@leonardder leonardder requested a review from michaelDCurran Nov 18, 2019
@michaelDCurran michaelDCurran merged commit 3285323 into nvaccess:master Nov 18, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Nov 18, 2019
michaelDCurran added a commit that referenced this pull request Nov 18, 2019
@leonardder leonardder deleted the BabbageCom:initialDisplayFix branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.