Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix dependencies for server-side deploy script #10604
Link to issue number:
Summary of the issue:
The server side deploy code ('nvdaAppveyorHook') relies on artifacts, they must be uploaded before the deploy step is run.
Description of how this pull request fixes the issue:
For ordering of appveyor
Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes
The server side deploy code ('nvdaAppveyorHook') relies on artifacts, they must be uploaded first. deploy_script is run before on_finish, so the artifacts were missing. Instead, use artifacts section, and also upload from on_failure. For ordering of appveyor yml phases, see: https://www.appveyor.com/docs/build-configuration/#build-pipeline
We know that the executable is present, since the name comes from the 'output' directory of the build. Though this depends on the artifact uploading being successful.