Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally play sounds when toggling screen curtain #10611

Merged
merged 4 commits into from Jan 12, 2020

Conversation

@leonardder
Copy link
Collaborator

leonardder commented Dec 11, 2019

Note: filed against beta.

Link to issue number:

Fixes #10602
Closes #10476

Summary of the issue:

There is currently no audible indication of the screen curtain turning on/off due to a configuration profile change.

Description of how this pull request fixes the issue:

Add screen curtain on/off sounds, provided by Andre Louis. Also make sure that the screen curtain is only activated once (i.e not reinitialized) when enabling permanently.

Testing performed:

Tested enabling/disabling the curtain using a config profile and the global command script.

Known issues with pull request:

While this strictly spoken does not fix #10476, I think having the ability to enable screen curtain in one profile while disabling it in another has too much benefits to justify making it a global setting. Specifying what settings should be global is a different issue.

Change log entry:

None needed

@josephsl

This comment has been minimized.

Copy link
Collaborator

josephsl commented Dec 15, 2019

Copy link
Collaborator

josephsl left a comment

Hi,

Two important things, both in user guide:

  1. Vision/screen curtain section: can you add a brief note about sounds to indicate screen curtain toggle?
  2. In line 1399: screen curtain is misspelled.

A minor thing about Andre's sounds: the "on" sound is heard predominantly from the left side. I think we should compensate for that somehow (or it could be my hearing or my headset).

Thanks.

@leonardder leonardder requested a review from josephsl Dec 17, 2019
Copy link
Collaborator

josephsl left a comment

Thanks.

@michaelDCurran michaelDCurran merged commit f194afa into nvaccess:beta Jan 12, 2020
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jan 12, 2020
@davidacm

This comment has been minimized.

Copy link
Contributor

davidacm commented Jan 15, 2020

is just my mind or is the sound (ON / OFF) not clear enough?
I can identify it, but it could be difficult for people with hearing loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.