Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table movement commands in list skipping empty cells #10623

Merged
merged 1 commit into from Dec 15, 2019

Conversation

@leonardder
Copy link
Collaborator

leonardder commented Dec 14, 2019

Link to issue number:

Fixes #10615

Summary of the issue:

In #9873, we started ignoring columns that were taking no space. For this to work with table navigation as well, I changed the object commands to their simple equivalents, i.e. next to simpleNext, firstChild to simpleFirstChild. This logic relies on presentationType, which is set to layout for objects without name. Therefore, if cells don't have a name and reporting of cell coords is off, these empty cells are skipped when using table nav.

Description of how this pull request fixes the issue:

Reverted back to next/previous/firstChild and use a loop to skip cells that are invisible.

Testing performed:

Tested in the list view control as in #10615. Set the width of the second column to 0. Made sure that invisible columns are still skipped.

Known issues with pull request:

None

Change log entry:

None needed.

@michaelDCurran michaelDCurran merged commit 6e2f5aa into nvaccess:beta Dec 15, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.