Add unicode minus symbol

[JamesCatt]

Adds support for the unicode minus symbol, including when used for a negative number.

Link to issue number:

Fixes #10633

Summary of the issue:

NVDA does not identify negative numbers (including currencies) that use the unicode minus symbol, or announce unicode minus symbol in general.
Information on the minus symbol (U+2212)

Description of how this pull request fixes the issue:

• Updates negative number regex to work with unicode minus in addition to existing dash
• Adds minus to symbol list

Testing performed:

• Existing unit tests
• Confirmed working with:
  • Chrome 79
  • Firefox 72.0b7
  • IE11
  • MS Edge 44 (EdgeHTML)
  • MS Edge 80 (Chromium)
• Also confirmed negative numbers still work with dash in addition to minus

Known issues with pull request:

None

Change log entry:

Bug Fixes
Fixed not announcing Unicode minus symbol (U+2212) (#10633)

[LeonarddeR]

Note that this isn't an utf-8 symbol but an Unicode symbol. Utf-8 is an encoded representation of Unicode.

[JamesCatt]

Note that this isn't an utf-8 symbol but an Unicode symbol. Utf-8 is an encoded representation of Unicode.

Roger that, my mistake. Updated the PR to correct that. Thanks for pointing it out.

[JamesCatt]

@LeonarddeR should I be requesting a review from someone? If so, who would you suggest? Tx

[Adriani90]

@JamesCatt you can request review from @michaelDCurran or from @feerrenrut in this case since they are from NV Access and the only people who can merge pull requests into master, beta or any other branch.

[JamesCatt]

@JamesCatt you can request review from @michaelDCurran or from @feerrenrut in this case since they are from NV Access and the only people who can merge pull requests into master, beta or any other branch.

Will do, thanks!

[StommePoes]

Does this allow minus to be read out if it's not directly prefacing a financial symbol? For example, a math sentence: 3 − 2 ? (with a space after it?)

I'm rusty on my regexen, but I think that's what I'm seeing: just as a dash on its own is generally silent but sounds "minus" when directly next to a number, does this mean we still have zero recourse to get the − character itself to be read at some punctuation level?

[JamesCatt]

Does this allow minus to be read out if it's not directly prefacing a financial symbol? For example, a math sentence: 3 − 2 ? (with a space after it?)

I'm rusty on my regexen, but I think that's what I'm seeing: just as a dash on its own is generally silent but sounds "minus" when directly next to a number, does this mean we still have zero recourse to get the − character itself to be read at some punctuation level?

Nope, I added a standalone entry for the character as well (see line 59 in the diff), so it will be announced regardless of the context it appears in.

[feerrenrut]

This looks good, I added some information to the PR description about the exact Unicode symbol (U+2212).

I have tested this (very quickly) with espeak, I assume @JamesCatt you did the same. Please could you test with several other synthesizers, in particular OneCore.

I'll merge this now, but please comment on here to let me know which synthesizers have been tested. Thanks for the contribution!

[JamesCatt]

I'll merge this now, but please comment on here to let me know which synthesizers have been tested. Thanks for the contribution!

Will do, and thanks!