Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add unicode minus symbol #10636
Adds support for the unicode minus symbol, including when used for a negative number.
Link to issue number:
Summary of the issue:
NVDA does not identify negative numbers (including currencies) that use the unicode minus symbol, or announce unicode minus symbol in general.
Description of how this pull request fixes the issue:
Known issues with pull request:
Change log entry:
Does this allow minus to be read out if it's not directly prefacing a financial symbol? For example, a math sentence: 3 − 2 ? (with a space after it?)
I'm rusty on my regexen, but I think that's what I'm seeing: just as a dash on its own is generally silent but sounds "minus" when directly next to a number, does this mean we still have zero recourse to get the
Nope, I added a standalone entry for the character as well (see line 59 in the diff), so it will be announced regardless of the context it appears in.
feerrenrut left a comment
This looks good, I added some information to the PR description about the exact Unicode symbol (U+2212).
I have tested this (very quickly) with espeak, I assume @JamesCatt you did the same. Please could you test with several other synthesizers, in particular OneCore.
I'll merge this now, but please comment on here to let me know which synthesizers have been tested. Thanks for the contribution!