Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation in Windows Console: revert for 2019.3 #10684

Merged
merged 11 commits into from Jan 14, 2020

Conversation

@codeofdusk
Copy link
Collaborator

codeofdusk commented Jan 14, 2020

Link to issue number:

Completes #10682.

Summary of the issue:

It was decided to revert to legacy console support for 2019.3, but various UI and user guide elements remain from #9771.

Description of how this pull request fixes the issue:

  • The auto config setting is reverted to 2019.2 behavior (i.e. it maps to legacy).
  • The UI is returned to 2019.2 state (i.e. a simple checkbox). We really should move users to UIA once it becomes the default, and users who turn on UIA to experiment during development and then switch back to legacy wouldn’t automatically be upgraded.
  • References to “legacy” consoles removed from UI and user guide.

Testing performed:

Tested an upgrade from NVDA 2019.2.1 (stable) to this PR. Insured that legacy console is used by default and the UIA checkboxes are functional.

Known issues with pull request:

None.

Change log entry:

None needed.

@codeofdusk codeofdusk changed the base branch from master to beta Jan 14, 2020
@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Jan 14, 2020

@codeofdusk codeofdusk force-pushed the codeofdusk:revert-cmduia-20193 branch from 2e500a8 to 3196ed4 Jan 14, 2020
@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Jan 14, 2020

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Jan 14, 2020

See test results for failed build of commit 31d53948c5

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Jan 14, 2020

See test results for failed build of commit cfbf2d636c

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Jan 14, 2020

See test results for failed build of commit eed2b734c3

…cy, as fixing this seems out of scope for this PR).
@codeofdusk

This comment has been minimized.

Copy link
Collaborator Author

codeofdusk commented Jan 14, 2020

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Jan 14, 2020

See test results for failed build of commit 2eaecfc37c

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

michaelDCurran commented Jan 14, 2020

the 'and's need to be on the start of the next line to stop the linting issues I think.

@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Jan 14, 2020

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

@AppVeyorBot

This comment has been minimized.

@codeofdusk

This comment has been minimized.

Copy link
Collaborator Author

codeofdusk commented Jan 14, 2020

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

No, not quite. This PR reverts some additional UI, user guide, and behavior changes that were needed when UIA was the default.

@codeofdusk

This comment has been minimized.

Copy link
Collaborator Author

codeofdusk commented Jan 14, 2020

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

No, not quite. This PR reverts some additional UI, user guide, and behavior changes that were needed when UIA was the default.

It also keeps "auto" as the default config spec setting, allowing users to freely enable/disable UIA console during development and be automatically switched when it becomes the default.

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Jan 14, 2020

See test results for failed build of commit 5942d1788e

@michaelDCurran michaelDCurran merged commit 82eeff0 into nvaccess:beta Jan 14, 2020
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jan 14, 2020
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.