Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting of "not checked" for check boxes with no other states in browse mode. #10781

Merged
merged 1 commit into from Feb 12, 2020

Conversation

jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Feb 12, 2020

Link to issue number:

none. Fixes a regression introduced by #7279.

CC @leonardder.

Summary of the issue:

STR:

  1. Open this test case in Firefox:
    data:text/html,<div role="checkbox">test
  2. Press down arrow to read the check box in browse mode.
    • Expected: NVDA should say "check box not checked test".
    • Actual: NVDA says just "check box test".

Description of how this pull request fixes the issue:

When determining whether the caller wants states, we must differentiate between None and the empty set. If the caller didn't want states, states will be None. However, empty states means the caller still wants states, but the object had no states; e.g. an unchecked check box with no other states. After #7279 but before this PR, we treated an empty set as if the caller didn't want states.

Testing performed:

As above.

Known issues with pull request:

None known.

Change log entry:

Bug fixes:
- In browse mode, NVDA now reports "not checked" for unchecked check boxes where it sometimes didn't previously.

@jcsteh jcsteh requested a review from michaelDCurran Feb 12, 2020
…n browse mode.

When determining whether the caller wants states, we must differentiate between None and the empty set.
If the caller didn't want states, states will be None.
However, empty states means the caller still wants states, but the object had no states; e.g. an unchecked check box with no other states.
Previously, we treated an empty set as if the caller didn't want states.
@michaelDCurran michaelDCurran merged commit 39274e5 into nvaccess:master Feb 12, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Feb 12, 2020
michaelDCurran added a commit that referenced this issue Feb 12, 2020
@jcsteh jcsteh deleted the fixNotChecked branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants