Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX FOR SAPI4 SYNTHESIZERS #10792

Merged
merged 3 commits into from Feb 19, 2020
Merged

Conversation

dawidpieper
Copy link
Contributor

Summary of the issue:

In NVDA 2019.3 some SAPI4 synthesizers like Syntalk don't work properly. as the final index is not get by Screenreader.
As a result, when focusing some lists or explorer windows, the highlighted element is not reported. Also spelling does not work.

Description of how this pull request fixes the issue:

As the sequence is closed by some synthesizers just after reaching the last string in queue, we simply add 1ms break after all sequences sent to SAPI4 voice.

Testing performed:

The last index in speech sequence is sent to NVDA again. When focusing the desktop or using tab to navigate across elements, all items are now reported properly.
This was ested both on Windows 10 and Windows 7 and confirmed by some users from Poland.

Known issues with pull request:

None issues found.
The drawback is that spelling may prove to slow down a bit after implementing this solution.

Change log entry:

Bug fixes
SAPI4 voices should now properly report once the speak is completed

Added 1ms break after SAPI4 speech sequence as some synthesizers like Syntalk are completing the sequence just after last text, ignoring additional indexing
@AppVeyorBot
Copy link

See test results for failed build of commit 5618c4c158

@AppVeyorBot
Copy link

See test results for failed build of commit f4cd96abfc

Copy link
Collaborator

@leonardder leonardder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable workaround.

@zstanecic
Copy link
Contributor

zstanecic commented Feb 17, 2020 via email

@btman16
Copy link

btman16 commented Mar 27, 2020

Hi,

A similar issue exists at issue 10901.

Except that has to do with SAPI5.

Thanks,

B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants