Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brailleInput.handler.sendChars: allow sending Unicode characters beyond U+FFFF #10796

Merged
merged 1 commit into from Jul 3, 2020

Conversation

aaclause
Copy link
Contributor

@aaclause aaclause commented Feb 18, 2020

Link to issue number:

None

Summary of the issue:

We currently don't properly send an Unicode characters beyond U+FFFF from the braille input.

>>> brailleInput.handler.sendChars("😆")
>>> 

Description of how this pull request fixes the issue:

Break UTF-32 characters into its UTF-16 surrogate pair and send them using SendInput.

Testing performed:

Tested the previous test with a try build.
Also I addded this patch to Braille Extender add-on since awhile. The add-on allows send any Unicode character via HUC/hexadecimal/decimal/octal/binary value of the character. Tested with several Unicode characters beyond U+FFFF.

Known issues with pull request:

None

Change log entry:

Section: bug fixes

- You can now send Unicode characters beyond U+FFFF from a braille display. (#10796)

@AppVeyorBot
Copy link

AppVeyorBot commented Feb 18, 2020

See test results for failed build of commit 01f923b69e

@leonardder
Copy link
Collaborator

leonardder commented Feb 18, 2020

I wonder whether there is a cleaner way to do this than using struct.

@michaelDCurran
Copy link
Member

michaelDCurran commented Jun 23, 2020

Is this really just a change to an API, or is there a practical use case with a physical braille display you can describe here?

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented Jul 2, 2020

@Andre9642 Could you please respond to this commend by @michaelDCurran ?

@aaclause
Copy link
Contributor Author

aaclause commented Jul 2, 2020

Is this really just a change to an API, or is there a practical use case with a physical braille display you can describe here?

Assumme you have a braille table contains the following rule:

sign \y1f606 23478 # 😆

Currently, if we enter dots 2-3-4-7-8 from braille keyboard,  (U+f606) is printed instead of 😆 (U+1f606).

@michaelDCurran michaelDCurran merged commit 6154658 into nvaccess:master Jul 3, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.3 milestone Jul 3, 2020
michaelDCurran added a commit that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants