Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liblouis to 3.13.0 #10832

Merged
merged 2 commits into from Mar 30, 2020
Merged

Update liblouis to 3.13.0 #10832

merged 2 commits into from Mar 30, 2020

Conversation

leonardder
Copy link
Collaborator

@leonardder leonardder commented Mar 2, 2020

Link to issue number:

None

Summary of the issue:

Liblouis 3.13.0 has just been released.

Description of how this pull request fixes the issue:

Update to liblouis 3.13.0, which apart from a new German braille table has no new or removed tables. The new tables haven't been added yet, as I"m not sure how they fit in the current list of tables. Any feedback would be appreciated.

Testing performed:

T.b.d.

Known issues with pull request:

None

Change log entry:

  • Changes
    • Updated liblouis braille translator to 3.13.0

@zstanecic
Copy link
Contributor

zstanecic commented Mar 2, 2020

@leonardder
Copy link
Collaborator Author

leonardder commented Mar 2, 2020

@zstanecic I assume that's already in and doesn't require a change?

@zstanecic
Copy link
Contributor

zstanecic commented Mar 2, 2020

@zstanecic
Copy link
Contributor

zstanecic commented Mar 2, 2020

@DrSooom
Copy link

DrSooom commented Mar 3, 2020

@leonardder: I suggest to add "(improved back-translation, experimental)" to the two new German entries.
CC: @Adriani90

@leonardder
Copy link
Collaborator Author

leonardder commented Mar 4, 2020

I think it is enough to reference the new version of liblouis. If people want to know what's new, they can refer to the liblouis changelog. May be it makes sense to refer to their changelog from ours.

@leonardder leonardder marked this pull request as ready for review Mar 4, 2020
@leonardder leonardder requested a review from michaelDCurran Mar 4, 2020
@bdorer
Copy link
Sponsor

bdorer commented Mar 8, 2020

That's a great idea to reference liblouis' news file.

@DrSooom
Copy link

DrSooom commented Mar 9, 2020

But then please don't forget to save these pages in the Wayback Machine.

@zstanecic
Copy link
Contributor

zstanecic commented Mar 10, 2020

yep, good.
leonardder,
what's the progress of this?

@leonardder
Copy link
Collaborator Author

leonardder commented Mar 10, 2020

@zstanecic
Copy link
Contributor

zstanecic commented Mar 10, 2020

@mdcurran
Copy link

mdcurran commented Mar 10, 2020

You'll be wanting to CC @michaelDCurran I believe and not myself. 🙂

@zstanecic
Copy link
Contributor

zstanecic commented Mar 10, 2020

@leonardder
Copy link
Collaborator Author

leonardder commented Mar 11, 2020

@feerrenrut Could you please assess importance of this for 2020.1? I think it doesn't harm us to have it in.

@feerrenrut
Copy link
Member

feerrenrut commented Mar 11, 2020

As with any dependency update, it is best if it can get some testing time on alpha to reduce the risk of delaying the release. Since I'm not familiar with the full scope of changes, it's very hard to make an exception to rush this into the release. We are planning on starting the release process for 2020.2 shortly after release of 2020.1, which means it will not be long before this is released anyway if it doesn't go into 2020.1.

@leonardder
Copy link
Collaborator Author

leonardder commented Mar 23, 2020

It looks like the NVDA 2020.2 merge window has started. Could this be merged to have broad testing?

@DrSooom
Copy link

DrSooom commented Mar 28, 2020

@leonardder: See issue #10912. Unsure if this PR will solve that issue too. See also my previous comment.

@feerrenrut
Copy link
Member

feerrenrut commented Mar 30, 2020

Thanks for the reminder @leonardder

@feerrenrut feerrenrut merged commit 1ccc72c into nvaccess:master Mar 30, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Mar 30, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 Mar 30, 2020
feerrenrut added a commit that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants