Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to toggle the report of superscripts and subscripts #10985

Merged
merged 5 commits into from Apr 16, 2020

Conversation

CyrilleB79
Copy link
Contributor

@CyrilleB79 CyrilleB79 commented Apr 11, 2020

Link to issue number:

None

Summary of the issue:

Almost all items of the "Document formatting" setting panel have an associated script to toggle the feature. Since #10919 has been merged, it would be useful to have a script to toggle superscripts and subscripts reporting. For example the feature would be activated when reading a mathematical document with squared variables. But it should be deactivated when reading a normal document containing abbreviations such as 1st, 2nd, etc.

Description of how this pull request fixes the issue:

Add a script in global commands to toggle the reporting of superscripts and subscripts. This script has no default gesture assigned.

Testing performed:

  • Assigned a gesture to the script.
  • Open this page, and go to the demo output.
  • Toggle the superscripts and subscripts reading with the gesture and checked that superscripts were reported consequently when reading the following line:
    a2 + b2 = c2

Did not test with MS Word since there is a pending issue: #10979

Known issues with pull request:

This PR does not guarantee that all features of "Document formatting" setting panel has an associated script: cell border reporting is still missing. However there is already a PR for this (#10408)

Change log entry:

Section: New features

A script to toggle the report of subscripts and superscripts has been added.

or just modify the change log entry for #10919 to add this PR's information.

@CyrilleB79
Copy link
Contributor Author

CyrilleB79 commented Apr 11, 2020

@codeofdusk did you have any reason not to associate a dedicated script to superscripts/subscripts reporting toggle? I did not seen anything in #10919.

Cc @leonardder:
Can you also have a look at this one? Thanks.

@AppVeyorBot
Copy link

AppVeyorBot commented Apr 11, 2020

See test results for failed build of commit 16faf14428

Copy link
Member

@feerrenrut feerrenrut left a comment

One minor issue to address, otherwise this looks fine

source/globalCommands.py Outdated Show resolved Hide resolved
source/globalCommands.py Outdated Show resolved Hide resolved
CyrilleB79 and others added 2 commits Apr 14, 2020
@AppVeyorBot
Copy link

AppVeyorBot commented Apr 14, 2020

See test results for failed build of commit 2aeef4ccdd

@CyrilleB79
Copy link
Contributor Author

CyrilleB79 commented Apr 14, 2020

@feerrenrut, I have addressed your feedback and suggestion. Thanks.

Copy link
Member

@feerrenrut feerrenrut left a comment

Thanks @CyrilleB79

@feerrenrut feerrenrut merged commit 827ec77 into nvaccess:master Apr 16, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Apr 16, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 Apr 16, 2020
feerrenrut added a commit that referenced this pull request Apr 16, 2020
@codeofdusk
Copy link
Contributor

codeofdusk commented Apr 17, 2020

I think the existing changes entry should be modified to mention the script instead of adding to new features (the change itself is new to 2020.2).

@feerrenrut
Copy link
Member

feerrenrut commented Apr 17, 2020

I added a new entry, since there are now two new things you can do. Configure reporting, and toggle.

@codeofdusk
Copy link
Contributor

codeofdusk commented Apr 18, 2020

Maybe change the existing entry to something like:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants