Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brlapi to 0.8 #11065

Merged
merged 2 commits into from Apr 29, 2020
Merged

Update brlapi to 0.8 #11065

merged 2 commits into from Apr 29, 2020

Conversation

leonardder
Copy link
Collaborator

@leonardder leonardder commented Apr 28, 2020

Link to issue number:

None

Summary of the issue:

With the migration to Python 3, we had to update our brlapi dependency to 0.7 to support the brltty braille display driver. However, there wasn't an upstream build of the brlapi python bindings, therefore we had to build them ourselves.

Description of how this pull request fixes the issue:

Thanks to @DaveMielke, BRLTTY 6.1 bundles a brlapi binding built against Python 3.7 we could use directly from upstream. Note that it is still bundled inside our misc-deps repository.

Testing performed:

Tested a try build with brlapi 0.8 against an installed build of brltty 6.1. I'm pretty sure however that this brlapi should still be able to work with older versions of brltty, may be @DaveMielke can give some info on that.

Known issues with pull request:

None

Change log entry:

Copy link
Member

@feerrenrut feerrenrut left a comment

Thanks @leonardder

@feerrenrut feerrenrut merged commit 939217d into nvaccess:master Apr 29, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone Apr 29, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 Apr 29, 2020
feerrenrut added a commit that referenced this pull request Apr 29, 2020
@lukaszgo1
Copy link
Contributor

lukaszgo1 commented Apr 30, 2020

@leonardder While I no longer have the old ALVA which requires BRLTTY and therefore no BRLTTY is installed on my system, in the previous Alpha's it was possible to import brlapi anyway, and BRLTTY was present in the braille displays list whereas now it is not. Additionally there is no brlapi.dll in the NVDA folder anymore. Is this a change in brlapi bindings?

@leonardder
Copy link
Collaborator Author

leonardder commented Apr 30, 2020

Ugh, you're correct. Interesting enough, I tested this with a try build and that all went fine. It's this try build. Let me investigate what went wrong here.

@leonardder
Copy link
Collaborator Author

leonardder commented Apr 30, 2020

filed nvaccess/nvda-misc-deps#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants