Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Stop listening for IAccessible reorder events. #11076

Merged
merged 1 commit into from May 13, 2020

Conversation

jcsteh
Copy link
Contributor

@jcsteh jcsteh commented May 1, 2020

Link to issue number:

None.

Summary of the issue:

The only place we used reorder events in the NVDA process was Skype classic, which is dead now and which NVDA already dropped support for. I doubt this is having much of a real impact, since shouldAcceptEvent dropped them anyway, but it doesn't make sense to listen (and waste CPU cycles) for something we don't use.

Description of how this pull request fixes the issue:

Remove reorder from the win event map and remove code for reorder in shouldAcceptEvent.

Testing performed:

Not really much to test for, but browsed the web a bit just to be sure.

Known issues with pull request:

There might be add-ons which used requestEvent to listen for reorder. However, this is very unlikely. I grepped through all of the add-ons which have repositories on the NV Access server (which should be most of the add-ons on the official site) and didn't find event_reorder in any of them.

Change log entry:

Changes for developers:
- NVDA no longer listens for IAccessible EVENT_OBJECT_REORDER.

The only place we used these was Skype classic, which is dead now and which NVDA already dropped support for.
@feerrenrut
Copy link
Member

feerrenrut commented May 1, 2020

It would be worth also flagging this on the add-ons message board, despite being unlikely to cause a problem it goes against our intention to maintain a stable API until the next planned breakage.

@michaelDCurran michaelDCurran merged commit 85b3aa7 into nvaccess:master May 13, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.2 milestone May 13, 2020
michaelDCurran added a commit that referenced this pull request May 13, 2020
@jcsteh jcsteh deleted the reorder branch May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants