Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liblouis to 3.14.0 #11221

Merged
merged 2 commits into from Jun 10, 2020
Merged

Update liblouis to 3.14.0 #11221

merged 2 commits into from Jun 10, 2020

Conversation

aaclause
Copy link
Contributor

@aaclause aaclause commented Jun 2, 2020

Link to issue number:

None

Summary of the issue:

Liblouis 3.14.0 has just been released.

Description of how this pull request fixes the issue:

  1. Updates the liblouis submodule.
  2. Changes the readme.
  3. Adds the following tables: Uzbek grade 1, Israeli grade 1, Israeli 8 dot computer braille and Malay grade 2.

Testing performed:

Tested from source.

Known issues with pull request:

None

Change log entry:

  • Changes
    • Updated liblouis braille translator to 3.14.0 (from 3.13.0).

@zstanecic
Copy link
Contributor

zstanecic commented Jun 2, 2020

@zstanecic
Copy link
Contributor

zstanecic commented Jun 2, 2020

@aaclause
Copy link
Contributor Author

aaclause commented Jun 2, 2020

@zstanecic It's already done. Please read the PR description/the diff.

@codeofdusk
Copy link
Contributor

codeofdusk commented Jun 4, 2020

Are there plans to get this into 2020.2?

@codeofdusk
Copy link
Contributor

codeofdusk commented Jun 4, 2020

If you do, you'll want to change the changelog entry to:

Updated liblouis braille translator to 3.14.0 (from 3.12.0).

@zstanecic
Copy link
Contributor

zstanecic commented Jun 4, 2020

@zstanecic
Copy link
Contributor

zstanecic commented Jun 4, 2020

@feerrenrut feerrenrut added component/braille component/liblouis Issues related to liblouis, such as liblouis updates and braille table additions/changes maintenance/dependencyUpdate Maintenance of NVDA, specifically dependency updates. labels Jun 9, 2020
@dpy013
Copy link
Contributor

dpy013 commented Jun 9, 2020

hello
Will this pr be merged into NVDA 2020.2?
thanks

@zstanecic
Copy link
Contributor

zstanecic commented Jun 9, 2020

@dpy013
Copy link
Contributor

dpy013 commented Jun 9, 2020

@feerrenrut
Any suggestions?
thanks

@feerrenrut
Copy link
Member

feerrenrut commented Jun 9, 2020

@leonardder can you comment on how reliable/stable liblouis releases have been historically?

@leonardder
Copy link
Collaborator

leonardder commented Jun 9, 2020

@leonardder can you comment on how reliable/stable liblouis releases have been historically?

I don't recall any sever issues with liblouis release stability, other than the breakage that no longer allowed us to build it with VC++.
Version liblouis 3.14 has only a few source code changes, mostly table improvements as @zstanecic pointed out. It all depends on when you intend to release 2020.2, but if there is at least a period of around 4 weeks before that, I think it is safe to merge.

@zstanecic
Copy link
Contributor

zstanecic commented Jun 9, 2020

Copy link
Member

@feerrenrut feerrenrut left a comment

Changes look good, thanks @Andre9642

@feerrenrut
Copy link
Member

feerrenrut commented Jun 10, 2020

Thanks @leonardder. Given that we haven't started the beta releases yet, this should be plenty of time for this to get adequate testing. I'll merge this in.

@feerrenrut feerrenrut merged commit 87ed54a into nvaccess:master Jun 10, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.2 milestone Jun 10, 2020
@Futyn-Maker
Copy link

Futyn-Maker commented Jun 17, 2020

I understand that I've been bit late, but You've forgotten to include the new Ukrainian computer braille table. If it is possible before NVDA 2020.2 release, I'll very glad.

@dpy013
Copy link
Contributor

dpy013 commented Jun 17, 2020

I understand that I've been bit late, but You've forgotten to include the new Ukrainian computer braille table. If it is possible before NVDA 2020.2 release, I'll very glad.

liblouis Are there any related forms?

@Futyn-Maker
Copy link

Futyn-Maker commented Jun 17, 2020

liblouis Are there any related forms?

I didn't understand Your question, to be honest. The table was included in Liblouis 3.14 and called "uk-comp.utb"

Andrey

@aaclause
Copy link
Contributor Author

aaclause commented Jun 17, 2020

@Futyn-Maker I'm so sorry for that. :( To add tables, I was only refering to — New, renamed or removed tables — section from the changelog. This table is not listed here.

@aaclause aaclause deleted the liblouis3.14 branch Jun 17, 2020
@Futyn-Maker
Copy link

Futyn-Maker commented Jun 17, 2020

Yes, it is strange. The note about this table is in "Braille tables improvements"

• New table for Ukrainian computer braille thanks to Andrey Yakuboy and Oleh Shpai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/braille component/liblouis Issues related to liblouis, such as liblouis updates and braille table additions/changes maintenance/dependencyUpdate Maintenance of NVDA, specifically dependency updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants