Hide option to show braille messages indefinitely when messages timeout is set to 0

[dawidpieper]

Summary of the issue:

When user sets braille messages timeout to 0, option to show them indefinitely still appears. Its checking does not take any effect, though. I found it confusing for some people.

Description of how this pull request fixes the issue:

Now there is a combobox that enables users to set if braille messages should be displayed and for how long:

• Disabled - disables showing of braille messages
• Use timeout - Enables users to set custom timeout
• Show indefinitely - Messages never disappear automatically.

Checkbox to show messages indefinitely has been removed and timeout field is now shown only if "Use timeout" option is selected.

Testing performed:

All tests passed.

Known issues with pull request:

None yet

Change log entry:

Changes
Rebuilt option to set if braille messages should be shown and when they should disappear

[feerrenrut]

It may not be immediately obvious why this control is missing.

Instead, perhaps the following approach:

• Use a comboBox "Show braille messages", with options: "Disable", "Use timeout", "Show indefinitely"
• When "Use timeout" is selected, then the timeout control is enabled, otherwise it is disabled.

Also, please check the user guide and confirm that it describes these options well (or needs changes).

[dawidpieper]

Thank you, I think it would be a good approach. I'll try to prepare it tomorrow.

[feerrenrut]

Generally looks good, thanks @dawidpieper

[dawidpieper]

I've harcoded 1 as a minimum value. I don't know what is the main policy for config specs - readability or backward compatibility. I can also change config specs and prepare upgrade as suggested, if it is the preferred way.

[feerrenrut]

Thanks @dawidpieper