Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap F3 key for HIMS displays to avoi conflicts with number 6 in computer braille tables #11710

merged 2 commits into from Oct 1, 2020


Copy link

Link to issue number:

None, reported by users on one of the Polish mailing lists and subsequently confirmed by Polish distributor of HIMS displays.

Summary of the issue:

Currently for HIMS braille displays F3 key is assigned to the braille points 1248. For computer braille tables however (at least for the Polish one) dots 1248 should enter number 6. For users it is impossible to write "6" from the braille keyboard in computer braille on HIMS displays.

Description of how this pull request fixes the issue:

F3 key has been remapped to Space+148. If we assume that Space+point 8 is responsible for invoking F keys this mapping is logical since dots 14 represents number 3.

Testing performed:

TBD - I'll send the build to the distributor I don't have display to test.

Known issues with pull request:

None known

Change log entry:

Section: Bug fixes
It is now possible to enter number 6 in computer braille from a braille keyboard on HIMS displays.

For HIMS braille displays F3 has been remapped to Space + dots 148

leonardder previously approved these changes Oct 1, 2020
Copy link

@leonardder leonardder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me. Actually I blindly copied the gesture mapping from the old driver.

@michaelDCurran michaelDCurran merged commit 780f04d into nvaccess:master Oct 1, 2020
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Oct 1, 2020
@lukaszgo1 lukaszgo1 deleted the HIMS-remap_F3 branch October 2, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants