Workaround for Azure Data Studio #11715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feerrenrut
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Link to issue number:
Follow up of #11657
Summary of the issue:
Azure Data Studio is for data wat VS Code is for code. They share a lot of the same logic, and therefore Data Studio also suffers from the same performance issues as VS Code did without the workaround to disable the tree interceptor on the root node.
Description of how this pull request fixes the issue:
Inherrit from the app module of Code.
Testing performed:
Tested that performance improved as in Code.
Known issues with pull request:
None
Change log entry: