Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to official CLDR repository #11817

Merged
merged 7 commits into from Nov 26, 2020
Merged

Switch to official CLDR repository #11817

merged 7 commits into from Nov 26, 2020

Conversation

OzancanKaratas
Copy link
Collaborator

Link to issue number:

Fixes #10955

Summary of the issue:

We are currently using an unofficial submodule repository.

Description of how this pull request fixes the issue:

This pull request will migrate our submodule to the official repository.

Testing performed:

  1. Checked out to release 38.
  2. The files were compiled for NVDA.
  3. It works as expected.

Known issues with pull request:

See the discussion in #10955.

Change log entry:

Section: Changes

  • Updated CLDR emoji annotation to version 38.

Note: I want to be officially maintainer for this. I will track the changes and open a pull request if new updates arrived.

Thanks.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

See test results for failed build of commit 70fde2f6e5

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

See test results for failed build of commit 31641e0397

@OzancanKaratas
Copy link
Collaborator Author

@LeonarddeR, Linting error cannot be fixed. What should I do?

@LeonarddeR
Copy link
Collaborator

@feerrenrut I think we should consider disabling flake8 tests for our scons files. They are simply non-standard python files and will never conform to Flake8 checks unless ugly workarounds are applied.

LeonarddeR
LeonarddeR previously approved these changes Nov 9, 2020
Copy link
Collaborator

@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safe to ignore these linter errors for now.

@feerrenrut
Copy link
Contributor

Yes, I agree, lets exclude the scons files from the linter for now.

@LeonarddeR
Copy link
Collaborator

@OzancanKaratas If you don't mind, I've excluded the scons files from linting. Let's see whether it passes the tests now.

feerrenrut
feerrenrut previously approved these changes Nov 26, 2020
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feerrenrut feerrenrut merged commit 5f06d76 into nvaccess:master Nov 26, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Nov 26, 2020
@cary-rowen
Copy link
Contributor

Hi,

I found an error in zh_CN.

In the file "NVDA\locale\zh_CN\cldr.dic", line 61
The content of this line is "@ @ 符号 none"
This will cause NVDA to report "@" as "at-sign sign".
In fact, the content of this line should be "@ at none".

Thanks.

@OzancanKaratas
Copy link
Collaborator Author

@cary-rowen:

The content of this line is "@ @ 符号 none"
This will cause NVDA to report "@" as "at-sign sign".
In fact, the content of this line should be "@ at none".

This problem is caused by NVDA's lack of this mark in the Chinese dictionary file. To understand better, please refer to the symbols.dic file of the corresponding language file in the locale folder. Please contact the team that translated NVDA into Chinese to fix the issue. Unless this mark is translated, NVDA gets the description of the mark from the file cldr.dic.

@cary-rowen
Copy link
Contributor

Hi,

Thanks for your reply.
I have corrected this in "symbols.dic" in Simplified Chinese, but I still hope that "CLDR.dic" can also correct it.

Thanks
@OzancanKaratas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CLDR from the submodules
6 participants