Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove winKernel.GetTimeFormat, winKernel.GetDateFormat and usages #12139

Merged
merged 2 commits into from Mar 11, 2021

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Mar 9, 2021

Link to issue number:

Implement deprecations announced in #7949

Part of: #12123

Summary of the issue:

winKernel.GetTimeFormat and winKernel.GetDateFormat relied on deprecated Windows API functionality, as described here and here. "Any application that will be run only on Windows Vista and later should use GetTimeFormatEx."

Description of how this pull request fixes the issue:

This deprecated functionality was removed and any usages replaced with winKernel.GetTimeFormatEx and winKernel.GetDateFormatEx equivalents.

Testing strategy:

The only current usage was for focusing on selecting ranges in the Calendar View for Outlook (>=13). This can be done by selecting ranges in the Calendar View in outlook and ensuring the output (eg Speech Viewer) is consistently formatted.

Check for usages with

find . -type f -name '*.py' -exec grep -P "\bGetDateFormat\b" {} +
find . -type f -name '*.py' -exec grep -P "\bGetTimeFormat\b" {} +

Known issues with pull request:

None

Change log entry:

Section: Developer Changes

 - `winKernel.GetTimeFormat` has been removed - use `winKernel.GetTimeFormatEx` instead (#12139)
 - `winKernel.GetDateFormat` has been removed - use `winKernel.GetDateFormatEx` instead (#12139)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation. (N/A)
  • Change log entry.
  • Context sensitive help for GUI changes. (N/A)

@seanbudd seanbudd self-assigned this Mar 9, 2021
@seanbudd seanbudd added the deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release label Mar 9, 2021
@seanbudd seanbudd added this to the 2021.1 milestone Mar 9, 2021
@seanbudd seanbudd mentioned this pull request Mar 9, 2021
18 tasks
michaelDCurran
michaelDCurran previously approved these changes Mar 10, 2021
@seanbudd seanbudd merged commit 0d22a00 into master Mar 11, 2021
@seanbudd seanbudd deleted the dep-7949 branch March 11, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants