Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlTypes: Remove deprecated ROLE_EQUATION #12164

merged 2 commits into from Mar 16, 2021


Copy link

@lukaszgo1 lukaszgo1 commented Mar 14, 2021

Link to issue number:

None. Implements deprecation from 4fd4fb4

Summary of the issue:

ROLE_EQUATION in controlTypes has been deprecated since 2015 in favor of ROLE_MATH. Since 2021.1 is a compatibility breaking release it makes sense to remove code kept for backward compatibility.

Description of how this pull request fixes the issue:

ROLE_EQUATION has been removed.

Testing strategy:

With git grep ensured that only occurrence of the ROLE_EQUATION has been in the code removed as part of this pr.

Known issues with pull request:

None known

Change log entry:

Changes for developers:

- `ROLE_EQUATION` has been removed from controlTypes - use `ROLE_MATH`` instead. (#12164)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@lukaszgo1 lukaszgo1 mentioned this pull request Mar 14, 2021
18 tasks
@seanbudd seanbudd self-assigned this Mar 15, 2021
Copy link

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed that there were no other usages

Copy link

See test results for failed build of commit 78cbe4160c

@seanbudd seanbudd added the deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release label Mar 16, 2021
@seanbudd seanbudd added this to the 2021.1 milestone Mar 16, 2021
@seanbudd seanbudd merged commit d67c3c7 into nvaccess:master Mar 16, 2021
@lukaszgo1 lukaszgo1 deleted the deprecate_Role_EQUATION branch March 16, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants