Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DriverSetting classes from autoSettingUtils rather than from driverHandler #12168

Merged
merged 3 commits into from Mar 17, 2021

Conversation

lukaszgo1
Copy link
Contributor

Link to issue number:

None, removes code marked as kept for backwards compatibility in #10082

Summary of the issue:

PR #10082 refactored driverHandler and moved most of its content to a separate package autoSettingUtils. To preserve backwards compatibility most of autoSettingUtils were imported to driverHandler and these classes were used from driverHandler through the code.
Since 2021.1 is going to break add-ons anyway it makes sense to standardize this and remove these imports from driverHandler.

Description of how this pull request fixes the issue:

Unused imports are removed from driverHandler and all classes which were previously used from there are used from autoSettingUtils.

Testing strategy:

Inspected all usages of driverHandler with git grep - ensured that no usages of code from autoSettingUtils remains.

Known issues with pull request:

None known

Change log entry:

Section: changes for developers:

  • driverSetting classes are removed from driverHandler - please use them from autoSettingUtils

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@AppVeyorBot
Copy link

See test results for failed build of commit 49dd4e897c

@seanbudd seanbudd added the deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release label Mar 16, 2021
@seanbudd seanbudd added this to the 2021.1 milestone Mar 16, 2021
@seanbudd seanbudd self-assigned this Mar 17, 2021
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I can confirm that the usages have been removed by searching through code.

@seanbudd seanbudd merged commit b3b2e1f into nvaccess:master Mar 17, 2021
@lukaszgo1 lukaszgo1 deleted the dep10082DriverHandler branch March 17, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants