Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backwards compat code from IAccessibleHandler #12232

Conversation

lukaszgo1
Copy link
Contributor

Link to issue number:

None, removes code marked as deprecated in #10934

Summary of the issue:

PR #10934 refactored IAccessibleHandler into a package. This necessitated keeping some unused imports but marking them as deprecated. Also various parts of NVDA relied on the fact that IAccessibleHandler star imported all variables from IAccessible and IAccessible2 COM interfaces.

Description of how this pull request fixes the issue:

  • Unused imports are removed from IAccessibleHandler
  • NVDA's source has been modified to use IAccessible2 names from the COM interface rather than from IAccessibleHandler.

Testing strategy:

Manual testing:
Ensured that NVDA still starts, and works in general. Spend about an hour browsing in Firefox without any apparent changes in behavior.

With git grep inspected all usages of IAccessibleHandler to make sure that nothing in NVDA's source relies on things star imported there any longer.

Known issues with pull request:

None known

Change log entry:

Section: Changes for developers:

  • IAccessibleHandler no longer star imports everything from IAccessible and IA2 COM interfaces - please use them directly.

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@lukaszgo1
Copy link
Contributor Author

cc @seanbudd

@seanbudd seanbudd self-assigned this Mar 25, 2021
@seanbudd seanbudd added the deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release label Mar 25, 2021
@seanbudd seanbudd added this to the 2021.1 milestone Mar 25, 2021
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukaszgo1, looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants