Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting of superscript / subscript in Wordpad #12262

Merged
merged 3 commits into from Apr 20, 2021

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Apr 2, 2021

Link to issue number:

None

Summary of the issue:

In IAccessible edit field such as WordPad, enabling "Superscript and subscript" reporting in Document formatting settings was not enough to have them reported. It was also required to have Font attributes reporting enabled.
This is due to a forgotten part of the code when reporting of superscript/subscript has been separated from reporting of the other attributes in #10919.

Description of how this pull request fixes the issue:

Added the missing 'if' statement.

Testing strategy:

Manual tests:

  • In Document formatting options, enabled superscript and subscript reporting and disabled attributes reporting. Checked in Wordpad that superscript and subscript text is reported:
    • Moving character by character
    • Making the whole line read (with Report formatting changes after the cursor option enabled)
  • In Document formatting options, disabled superscript and subscript reporting and enabled attributes reporting. Checked in Wordpad that bold and underline is reported:
    • Moving character by character
    • Making the whole line read (with Report formatting changes after the cursor option enabled)

No specific unit test or system test.

Known issues with pull request:

None

Change log entry:

Section: Bug fixes
In WordPad, configuration of superscript/subscript reporting works as expected. (#12262)

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79, looks good to me

@seanbudd seanbudd merged commit ce28256 into nvaccess:master Apr 20, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 20, 2021
@CyrilleB79 CyrilleB79 deleted the fixSuperscriptSubscript branch April 20, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants