Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLDR to version 39.0 #12314

Merged
merged 24 commits into from
May 16, 2021
Merged

Update CLDR to version 39.0 #12314

merged 24 commits into from
May 16, 2021

Conversation

OzancanKaratas
Copy link
Collaborator

@OzancanKaratas OzancanKaratas commented Apr 20, 2021

Summary of the issue:

CLDR version 39.0 has been released.
http://cldr.unicode.org/index/downloads/cldr-39

Description of how this pull request fixes the issue:

Updates to the latest version of CLDR

Testing strategy:

Testing via Alpha users

Known issues with pull request:

None

Change log entries:

Changes

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@OzancanKaratas OzancanKaratas requested a review from a team as a code owner April 20, 2021 16:00
@OzancanKaratas
Copy link
Collaborator Author

CC: @LeonarddeR

CC: @michaelDCurran

@AppVeyorBot
Copy link

@feerrenrut
Copy link
Contributor

Hi @OzancanKaratas, please fill in the full PR template in the future. The more background information you can provide the easier it is for us to review. I have updated this for you.

This change does not build, I'm going to convert this to a draft. The error can be found via the appveyor console log, I'll paste it here:

Compiling gettext template source\locale\my\LC_MESSAGES\nvda.po
Generating source\locale\nb_NO\cldr.dic
scons: *** [source\locale\nb_NO\cldr.dic] AssertionError : cldrDict is empty
Traceback (most recent call last):
  File "C:\projects\nvda\.venv\lib\site-packages\SCons\Action.py", line 1280, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "C:\projects\nvda\cldrDict_sconscript", line 40, in <lambda>
    lambda target,source,env: createCLDRAnnotationsDict([src.path for src in source], target[0].path),
  File "C:\projects\nvda\cldrDict_sconscript", line 29, in createCLDRAnnotationsDict
    assert cldrDict, "cldrDict is empty"
AssertionError: cldrDict is empty
scons: building terminated because of errors.
Deactivating NVDA Python virtual environment
Command exited with code 2

Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure this change builds before converting back from draft.

@feerrenrut feerrenrut marked this pull request as draft April 21, 2021 07:41
@AppVeyorBot
Copy link

@OzancanKaratas OzancanKaratas marked this pull request as ready for review April 21, 2021 17:32
@CyrilleB79
Copy link
Collaborator

Does this PR fix #11963?

  • If yes, please add a reference to this issue in the change log.
  • If no, where does the issue come from?
    • If from NVDA could it be fixed in this PR also?
    • If from CLDR, is there an issue opened agains CLDR?

@OzancanKaratas
Copy link
Collaborator Author

Does this PR fix #11963?

I am not sure. Please test this pull request. However, this problem is not caused by CLDR, but by missing translations of the languages.

@CyrilleB79
Copy link
Collaborator

Does this PR fix #11963?

I am not sure. Please test this pull request. However, this problem is not caused by CLDR, but by missing translations of the languages.

I am not convinced that the issue comes from missing translations. Please see #11963 (comment) and comment there since it is a better place to continue this discussion in any case.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

commit 86fe20f
Author: Julien Cochuyt <JulienCochuyt@users.noreply.github.com>
Date:   Tue May 4 03:00:30 2021 +0200

    Elements List: Don't remove the label of a filled spin button input field (#12317) (#12318)

    In browse mode documents, when a spin button input field is filled with a value, its label goes missing from the Elements List dialog.

    Description of how this pull request fixes the issue:
    Remove the role ROLE_SPINBUTTON from the set of exceptions for which the content replaces the label.
cldrDict_sconscript Outdated Show resolved Hide resolved
@feerrenrut feerrenrut requested a review from LeonarddeR May 7, 2021 07:11
@feerrenrut
Copy link
Contributor

@LeonarddeR Would you mind reviewing this? I'm not very sure what to look for with a CLDR change, could you comment on what you would test / check for so myself and @seanbudd can be better equipped to handle these PRs in the future? Perhaps we should add a readme for this at include/cldr.md

Copy link
Collaborator

@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @OzancanKaratas

@codeofdusk
Copy link
Contributor

Do you plan to merge this in time for 2021.1?

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this and create an issue for "create a readme at include/cldr.md" which requires information on updating CLDR and anything else relevant? @feerrenrut

@seanbudd
Copy link
Member

Should we have more information in the changelog? It seems like more languages are supported now.

@feerrenrut
Copy link
Contributor

I don't feel confident to make a call on this PR. It isn't clear if this specifically fixes issues, and whether it introduces new ones.
We can merge it and see who shouts, but it would be nice if this was a little more targeted.

@OzancanKaratas
Copy link
Collaborator Author

@feerrenrut, I think this pull request should be merged. For users who are experiencing problems due to missing translations in the NVDA and CLDR repository, we should not ignore those who have no problems.

@michaelDCurran
Copy link
Member

I will merge this now, as it upgrades to cldr 39.0 and enables several new languages previously unavailable. However, to be very clear, this pr does not fix #11963 - This can only be done by switching to the cldr-staging repository and using the generated production data. I'll submit a pr for this once this one is merged.

@michaelDCurran michaelDCurran merged commit 9390d02 into nvaccess:master May 16, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone May 16, 2021
@OzancanKaratas OzancanKaratas deleted the cldr39 branch May 16, 2021 23:30
seanbudd pushed a commit that referenced this pull request May 17, 2021
Enables several new languages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants