Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille Viewer: Add a close button on the title bar for use with pointing devices #12328



Copy link

@JulienCochuyt JulienCochuyt commented Apr 23, 2021

Link to issue number:

As argued IMHO with reason by @bhavyashah in #10791 (comment)
This PR does not address #10791 which targets Speech Viewer.

Summary of the issue:

The Braille Viewer currently presents no close control on its GUI.
It can only be closed with alt+F4 or by means of the dedicated NVDA Tools menu entry.

Description of how this pull request fixes the issue:

Add a standard close button on the title bar of the Braille Viewer dialog.

Testing strategy:

Ensured the dedicated check-able NVDA Tools menu entry gets unchecked as it properly does when closing the dialog with alt+F4.
Ensured proper behavior is maintained during restarts with or without "show at start-up" being checked.

Known issues with pull request:

Change log entries:

The Braille Viewer now has a standard close button for easier interaction with users of pointing devices. The other ways of interacting with this dialog remain otherwise unchanged.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

Copy link

XLTechie commented Apr 23, 2021 via email

Copy link

I agree with @XLTechie, I think it could be useful for people to be aware of this new feature.

Copy link
Collaborator Author

@XLTechie, @alexarnaud,
Thanks for your feedback.
Please find a proposed change log entry in the updated description.
Glad you find this functionality useful.

Copy link

Can it also be reached by keyboard nav (either standard or braille)?
If so, I would suggest the following for changes:

The Braille Viewer now includes a visible close button for added convenience.

Copy link
Collaborator Author

@XLTechie wrote:

Can it also be reached by keyboard nav (either standard or braille)?

Only through object navigation. It is a standard dialog close button positioned at the right of the title bar and has no special UX whatsoever. It's sole intent is to be activated using a pointing device such as mouse or touch screen.

Still, feel of course really free to propose a better wording of the change log entry than the one I quickly wrote.
I'm not a native English speaker.

Copy link

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JulienCochuyt!

@seanbudd seanbudd merged commit e2d2696 into nvaccess:master Apr 29, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 29, 2021
@JulienCochuyt JulienCochuyt deleted the i10791-brailleViewerCloseButton branch April 29, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants