Braille Viewer: Add a close button on the title bar for use with pointing devices #12328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
As argued IMHO with reason by @bhavyashah in #10791 (comment)
This PR does not address #10791 which targets Speech Viewer.
Summary of the issue:
The Braille Viewer currently presents no close control on its GUI.
It can only be closed with
alt+F4
or by means of the dedicated NVDA Tools menu entry.Description of how this pull request fixes the issue:
Add a standard close button on the title bar of the Braille Viewer dialog.
Testing strategy:
Ensured the dedicated check-able NVDA Tools menu entry gets unchecked as it properly does when closing the dialog with
alt+F4
.Ensured proper behavior is maintained during restarts with or without "show at start-up" being checked.
Known issues with pull request:
Change log entries:
Changes
The Braille Viewer now has a standard close button for easier interaction with users of pointing devices. The other ways of interacting with this dialog remain otherwise unchanged.
Code Review Checklist: