Speech Viewer: allow to close with alt+F4 & add a close button on the title bar for use with pointing devices (#10791) #12330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… title bar for use with pointing devices (nvaccess#10791)
seanbudd
requested changes
Apr 28, 2021
seanbudd
reviewed
Apr 28, 2021
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
|
@seanbudd wrote:
Sadly, this box is only available for PRs made from forks owned by users but not for forks owned by organizations. |
…tions/nvda into i10791-speechViewerCloseButton
seanbudd
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10791
Summary of the issue:
The Speech Viewer currently has no close button nor can be closed with alt+F4.
As described by @Qchristensen in #10791 (comment), most dialogs in NVDA can be closed with alt+F4.
As argued by @bhavyashah in #10791 (comment), the Speech Viewer is especially useful for sighted testers who might be more familiar in using pointing devices than keyboard shortcuts.
Description of how this pull request fixes the issue:
Handle closing with alt+F4 & add a standard close button in the title bar of the dialog.
Testing strategy:
Tested all combinations of "show on start-up" and not, opening/closing with the menu/gesture/button of both Speech and Braille viewers.
Ensured the checked state of the menu entry does reflect the state of the dialog.
Known issues with pull request:
It might be interesting to make the dialog freeze then forcibly close it to ensure the menu entry checked state remains consistent in that case.
Change log entries:
Changes
The Speech Viewer can now be closed with
alt+F4and has a standard close button for easier interaction with users of pointing devices. The other ways of interacting with this dialog remain otherwise unchanged.Code Review Checklist: