Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report if an object has details in browseMode #12439

Merged
merged 4 commits into from May 26, 2021
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented May 20, 2021

Link to issue number:

None

Summary of the issue:

#12364 added a command to read the summary of the aria-details. To know whether or not an object has details, this should be reported. However, new users might not want to use this feature so #12409 added a config setting to opt-in.

Description of how this pull request fixes the issue:

Discards the "has details" state change message unless the annotations config option is turned on.

Testing strategy:

Chrome system tests have been added.

Manual testing should be done in firefox using the test sample.

Known issues with pull request:

None

Change log entries:

New features (under annotations)

  • adds an option in advanced to report if an object has details in browse mode.

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd seanbudd requested a review from a team as a code owner May 20, 2021 01:41
@XLTechie
Copy link
Collaborator

XLTechie commented May 21, 2021 via email

Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seanbudd seanbudd merged commit ea88888 into master May 26, 2021
@seanbudd seanbudd deleted the discoveryAnnotations branch May 26, 2021 03:27
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone May 26, 2021
feerrenrut added a commit that referenced this pull request Jan 10, 2022
Summary:
Follows from #12439
Reporting "has details" and summarizing the details was not supported in focus mode or content editable.

Description of change:
- Adds system tests for focus mode / content editable
- Exposes an in-process approach to summarize an IAccessible
 getTextFromIAccessible moved from ia2LiveRegions.cpp to textFromIAccessible.h/cpp
 and exposed as nvdaInProcUtils_getTextFromIAccessible via IA2Support.cpp
- Now it is easier to fetch the details relation targets from python code.
- Updates reporting of has details and details summary to work in both browse and focus mode.

Known issues:
Currently only a single relation can be summarized. Support for multiple details 
relations will be added later, there are various UX concerns that will need to be resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants