Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bengali characterDescriptions.dic #12502

Merged
merged 3 commits into from Jul 6, 2021
Merged

Update Bengali characterDescriptions.dic #12502

merged 3 commits into from Jul 6, 2021

Conversation

Oymate
Copy link
Contributor

@Oymate Oymate commented Jun 2, 2021

Link to issue number:

N/A added missing entries

Summary of the issue:

Entries were missing

Description of how this pull request fixes the issue:

These entries fulfills the alphabet word list.

Testing strategy:

Known issues with pull request:

Change log entries:

Bug fixes

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@gregjozk
Copy link
Contributor

gregjozk commented Jun 2, 2021

Hello,

please first read carefully articles about translation on NVDA's github wiki and then join NVDA translation list where you can search existing Bengali maintainer if there is someone. He/she would incorporate your suggested changes into appropriate file. if there is no one, then you can become a bengali maintainer and start to translate NVDA, when you would resieved and accept assembla invitation sent to you by one of admins of translation list and system.
hope, it helps.

@lukaszgo1
Copy link
Contributor

It seems Bengali is sort of a special case - see #4410 especially comments 5 and 13. To recap there is no interest in translating NVDA into Bengali whereas there was demand to have Bengali letters reported so it was decided to commit these symbol files directly to Git as not to create unneeded work in the translations system.

@Oymate
Copy link
Contributor Author

Oymate commented Jun 3, 2021

How much time do you think translating to Bengali would require? This software is advertised on Bangladesh gov site as a screen reading solution so this is worrying

@zstanecic
Copy link
Contributor

zstanecic commented Jun 3, 2021 via email

@Oymate
Copy link
Contributor Author

Oymate commented Jun 3, 2021

Despite being unmaintained given the character description is already there, wouldn't it make more sense to merge them?

Side question: where can I find out how good espeak ng supports Bengali?

@Oymate Oymate closed this Jul 5, 2021
@CyrilleB79
Copy link
Collaborator

@Oymate, can you indicate the reason why you have closed this PR.
According to #12502 (comment), it seems it's a valid case to merge these modifications via GitHub and not via the SVN repo.
I am not qualified however to judge of the content of this PR, knowing nothing about Bengali language.

@Oymate
Copy link
Contributor Author

Oymate commented Jul 5, 2021

@CyrilleB79 I mainly didn't keep this open, because the devs seems not interested to merge this unless someone does full work on speech synthesis in Bangla. It really won't be any different since the char description is already here just not updated.

@Oymate Oymate reopened this Jul 5, 2021
@CyrilleB79
Copy link
Collaborator

@Oymate there has not yet been any comment from NVAccess core dev in this PR, just from contributors (even if some of them are quite active).
NVAccess priorize PRs as they wantand can . But being low priority does not mean uninteresting.
Also, NVAccess will review and merge PRs when they are set ready, i.e. not in draft state anymore. This PR is currently still in draft state.

@Oymate Oymate marked this pull request as ready for review July 5, 2021 09:29
@Oymate Oymate requested a review from a team as a code owner July 5, 2021 09:29
@Oymate Oymate requested a review from seanbudd July 5, 2021 09:29
@seanbudd seanbudd changed the title Update characterDescriptions.dic Update Bengali characterDescriptions.dic Jul 6, 2021
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If there is interest in people translating Bengali in our standard translation system (likely, the new one we are working on), please raise a new issue.

@seanbudd
Copy link
Member

seanbudd commented Jul 6, 2021

Or contact the translations google group mailing list https://groups.io/g/nvda-translations

@seanbudd seanbudd merged commit a847794 into nvaccess:master Jul 6, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jul 6, 2021
@Oymate Oymate deleted the patch-1 branch July 6, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants