Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liblouis to 3.18.0 #12526

Merged
merged 5 commits into from Jun 10, 2021
Merged

Update liblouis to 3.18.0 #12526

merged 5 commits into from Jun 10, 2021

Conversation

aaclause
Copy link
Contributor

@aaclause aaclause commented Jun 7, 2021

Link to issue number:

None

Summary of the issue:

Liblouis 3.18.0 has just been released.

Description of how this pull request fixes the issue:

Updates liblouis to 3.18.0 which adds support for many new languages and other awesome things.

Testing strategy:

  • Ran from sources.
  • Tested new braille tables (input and output).

Known issues with pull request:

None

Change log entries:

Section: Changes

- Updated liblouis braille translator to [3.18.0 https://github.com/liblouis/liblouis/releases/tag/v3.18.0]. (#12526)
  - New braille tables: Bulgarian grade 1, Burmese grade 1, Burmese grade 2, Kazakh grade 1, Khmer grade 1, Northern Kurdish grade 0, Sepedi grade 1, Sepedi grade 2, Sesotho grade 1, Sesotho grade 2, Setswana grade 1, Setswana grade 2, Tatar grade 1, Vietnamese grade 0, Vietnamese grade 2, Southern Vietnamese grade 1, Xhosa grade 1, Xhosa grade 2, Yakut grade 1, Zulu grade 1, Zulu grade 2

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@aaclause
Copy link
Contributor Author

aaclause commented Jun 8, 2021

There are several grade 2 tables that are not declared as contracted. I think these are mistakes. Here are the corresponding lines (git blame format):

ec877feab2 (Leonard de Ruijter 2018-12-06 03:48:12 +0100 105) addTable("ar-ar-g2.ctb", _("Arabic grade 2"))
ec877feab2 (Leonard de Ruijter 2018-12-06 03:48:12 +0100 222) addTable("es-g2.ctb", _("Spanish grade 2"))
83738d7d91 (André-Abush Clause 2021-03-22 11:15:08 +0100 444) addTable("ur-pk-g2.ctb", _("Urdu grade 2"))
d1ba63ab8f (Leonard de Ruijter 2018-09-04 07:46:41 +0200 459) addTable("zhcn-g2.ctb", _("Chinese (China, Mandarin) grade 2"))

Should I make another Pull Request for that?

CC @LeonarddeR

@aaclause aaclause marked this pull request as ready for review June 9, 2021 06:17
@aaclause aaclause requested a review from a team as a code owner June 9, 2021 06:17
@aaclause aaclause requested a review from seanbudd June 9, 2021 06:17
@Futyn-Maker
Copy link

Hello! Can it be included in NVDA 2021.1? Or Or is it too late?

@LeonarddeR
Copy link
Collaborator

I'm afraid it's too late for that.

@seanbudd
Copy link
Member

Thanks again, this looks like a great update! I noticed that the "PR description is up to date is unticked. Can you say why that is? Is it because we are uncertain of the following known issue:

There are several grade 2 tables that are not declared as contracted. I think these are mistakes.

@LeonarddeR @aaclause - should we proceed with this given the raised issue?

Hello! Can it be included in NVDA 2021.1? Or Or is it too late?

Sorry, this will have to wait until 2021.2.

@aaclause
Copy link
Contributor Author

aaclause commented Jun 10, 2021

@LeonarddeR @aaclause - should we proceed with this given the raised issue?

That's my question :). Only 4 SLOC are affected but given that it is not related to liblouis 3.18 it's likely irrelevant in this PR (?).

Also I'd like to suggest to change the display names of some braille tables in the GUI, like this:

  • Northern Kurdish grade 0 → Kurdish (Northern) grade 0
  • Central Kurdish grade 1 → Kurdish (Central) grade 1
  • Southern Vietnamese grade 1 → Vietnamese (Southern) grade 1

This way all Kurdish and Vietnamese tables would be gathered (currently scattered due to alphanumeric sorting). What do you think?

@seanbudd seanbudd requested a review from LeonarddeR June 10, 2021 03:56
@seanbudd
Copy link
Member

That's my question :). Only 4 SLOC are affected but given that it is not related to liblouis 3.18 it's likely irrelevant in this PR (?).

Cool, I will wait to see what @LeonarddeR thinks as well.

This way all Kurdish and Vietnamese tables would be gathered (currently scattered due to alphanumeric sorting). What do you think?

I agree, that would also be a good change. Might be worth noting that it differs to liblouis in a comment if that is the case.

@LeonarddeR
Copy link
Collaborator

I think it would be best to merge this pr as is. @aaclause raises valid points and therefore it makes sense to address them, but preferably in a follow up.

@seanbudd seanbudd merged commit 94b8fa2 into nvaccess:master Jun 10, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jun 10, 2021
@aaclause aaclause deleted the liblouis-3.18 branch June 10, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants