Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for some grade 2 braille tables that are not declared as contracted #12541

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

aaclause
Copy link
Contributor

@aaclause aaclause commented Jun 12, 2021

Link to issue number:

Follow up #12526 (comment)

Summary of the issue:

There are some grade 2 braille tables that are not declared as contracted. As a result the braille input does not work well with these tables.

Description of how this pull request fixes the issue:

Just adds contracted=True to the corresponding tables.

Testing strategy:

Ran from sources, set "Spanish grade 2" as input braille table and tried several inputs.

Known issues with pull request:

None

Change log entries:

Section: Bug fixes
- The braille input works properly with the following contracted tables: Arabic grade 2, Spanish grade 2, Urdu grade 2, Chinese (China, Mandarin) grade 2. (#12541)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@AppVeyorBot

This comment has been minimized.

@seanbudd
Copy link
Member

don't worry about that system failure. I've redone the build for you.

@aaclause aaclause marked this pull request as ready for review June 13, 2021 06:30
@aaclause aaclause requested a review from a team as a code owner June 13, 2021 06:30
@seanbudd
Copy link
Member

@aaclause - was this a problem in the last release, or is this an unreleased issue? If it is unreleased (not in beta or 2020.4), we don't need to update the changelog on this I think.

@aaclause
Copy link
Contributor Author

@seanbudd This is an issue present for quite some time (not introduced in the latest release). According to the git blame in #12526 (comment) some lines date from 2018.

@seanbudd seanbudd merged commit de3aa3a into nvaccess:master Jun 23, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jun 23, 2021
@seanbudd
Copy link
Member

Thanks @aaclause and @LeonarddeR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants