Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update espeak to ab11439b18 #12568

Merged
merged 2 commits into from Jun 22, 2021
Merged

Update espeak to ab11439b18 #12568

merged 2 commits into from Jun 22, 2021

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Jun 21, 2021

Link to issue number:

None

Summary of the issue:

It is helpful to run the latest version of espeak.

Description of how this pull request fixes the issue:

Testing strategy:

  • note that there has been no changes since the commit that was reverted to the build process (f6d092a9c13d864ede78c493f64a7d32cde41f09).
git diff f6d092a9c13d864ede78c493f64a7d32cde41f09 ab11439b18238b7a08b965d1d5a6ef31cbb05cbb Makefile.am
git diff f6d092a9c13d864ede78c493f64a7d32cde41f09 ab11439b18238b7a08b965d1d5a6ef31cbb05cbb --stat
  • NVDA builds, ensure espeak continues to work as expected

Known issues with pull request:

May reintroduce #12465. If this is the case, espeak-ng/espeak-ng#950 will need to be updated. This may remain an issue when updating espeak in future.

As a short term solution I'll do a revert. However, since there is no test case that works for me and @valdisvi the bug might be reintroduced by accident later. [revert commit]

Originally posted by @jaacoppi in espeak-ng/espeak-ng#950 (comment)

Change log entries:

See changes.t2t diff

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@seanbudd seanbudd marked this pull request as ready for review June 21, 2021 04:50
@seanbudd seanbudd requested a review from a team as a code owner June 21, 2021 04:50
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @seanbudd

@seanbudd seanbudd merged commit 2b293f8 into master Jun 22, 2021
@seanbudd seanbudd deleted the updateEspeak branch June 22, 2021 23:33
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants