Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate appveyor projects #12615

Merged
merged 2 commits into from Jul 9, 2021
Merged

Separate appveyor projects #12615

merged 2 commits into from Jul 9, 2021

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Jul 5, 2021

Link to issue number:

None

Summary of the issue:

If many PR/try builds are queued, it can take a long time to build a release. Building tagged releases is an involved process for an NV Access developer and as such, should be prioritised.

Description of how this pull request fixes the issue:

Creates two separate new projects for tagged releases and other builds. This allows for priorities to be set in the online UI.

The merge strategy is to squash all the code changes after the move into one commit, and perform a merge commit.

Testing strategy:

Confirming the following diffs are expected

git diff master:appveyor.yml appveyor-tagged:appveyor/config-tagged.yml
git diff master:appveyor.yml appveyor-tagged:appveyor/config-non-tagged.yml

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@seanbudd seanbudd requested a review from a team as a code owner July 5, 2021 04:30
@seanbudd seanbudd changed the title Appveyor tagged Separate appveyor projects Jul 5, 2021
@AppVeyorBot
Copy link

See completed build of commit bea26e3c0d

Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think @michaelDCurran should also review this.

If many PR/try builds are queued, it can take a long time to build a release. Building tagged releases is an involved process for an NV Access developer and as such, should be prioritised.
This commit creates two separate new projects for tagged releases and other builds. This allows for priorities to be set in the online UI.
@seanbudd seanbudd merged commit 9e09abf into master Jul 9, 2021
@seanbudd seanbudd deleted the appveyor-tagged branch July 9, 2021 06:29
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jul 9, 2021
seanbudd added a commit that referenced this pull request Jul 12, 2021
This reverts commit 9e09abf, reversing
changes made to a47af19.
seanbudd added a commit that referenced this pull request Jul 12, 2021
)

This reverts commit 9e09abf, reversing
changes made to a47af19.

Summary of the issue:
Splitting the AppVeyor projects resulted in the build number being reset, and being tracked independently across projects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants