Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible driver window issues in Handy Tech driver #12618

Merged
merged 6 commits into from Jul 9, 2021

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Jul 6, 2021

Link to issue number:

Fixes regression caused by #9691

Summary of the issue:

When vendor-specific applications need direct access to a Handy Tech Braille display, they indicate this by sending a window message to a driver-created invisible window. #9691 introduced this window for the handy tech driver, but it had some serious issues when doing the following

  1. Select the handy tech driver with an attached device
  2. Select the driver again

The following is in the log

ERROR - unhandled exception (08:42:07.717) - MainThread (9088):
Traceback (most recent call last):
  File "wx\core.pyc", line 3407, in <lambda>
  File "brailleDisplayDrivers\handyTech.pyc", line 650, in create_message_window
  File "windowUtils.pyc", line 150, in __new__
RuntimeError: Only one instance of InvisibleDriverWindow may exist at a time

Description of how this pull request fixes the issue:

This pr, among renaming some methods according to our guide lines, ensures that only one invisible driver window can be active by saving it on the class instead on instances of the class.

Testing strategy:

Switched from manual to automatic detection and back several times, without errors.

Known issues with pull request:

None known

Change log entries:

Bug fixes

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@LeonarddeR LeonarddeR requested a review from a team as a code owner July 6, 2021 06:44
@LeonarddeR LeonarddeR requested a review from seanbudd July 6, 2021 06:44
@seanbudd seanbudd merged commit b8b88b0 into nvaccess:master Jul 9, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants