Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appModules/SearchUI: add 'searchhost' as an alias of Search UI app module in Windows 11 #12628

Merged
merged 4 commits into from Jul 12, 2021

Conversation

josephsl
Copy link
Collaborator

@josephsl josephsl commented Jul 9, 2021

Hi,

Another part of #12585:

Link to issue number:

Expands #10341

Summary of the issue:

Windows Search executable was renamed to searchhost.exe in Windows 11, affecting suggestion count announcement.

Description of how this pull request fixes the issue:

Add an alias app module named "searchhost.py" to support suggestions count announcement in Windows 11.

Testing strategy:

Manual testing:

  1. In Windows 11 preview, open File Explorer (Windows+E).
  2. Press F3 to open search interface.
  3. Type something. NVDA should announce suggestion count.

Known issues with pull request:

None

Change log entries:

Tweaking #10341 to say:

New features:
In Windows 10 Version 1909 and later (including Windows 11), NVDA will announce suggestion count when performing searches in File Explorer. (#10341, #12628)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

…dows 11.

Windows Search executable was renamed to searchhost.exe in Windows 11, affecting suggestion count announcement. Therefore add an alias app module to support Windows 11.
@josephsl josephsl requested a review from a team as a code owner July 9, 2021 04:18
@josephsl josephsl requested a review from seanbudd July 9, 2021 04:18
josephsl and others added 3 commits July 9, 2021 00:15
Note from Sean Budd (NV Access): use __all__ to specify module attributes and to avoid Flake8 NOQA comment in the process.

Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@seanbudd seanbudd merged commit 4087ad9 into nvaccess:master Jul 12, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jul 12, 2021
@josephsl josephsl deleted the w11searchhost branch July 12, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants