Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that clipboard manager does not steal focus when starting MS Office programs #12736

Merged

Conversation

lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Aug 14, 2021

Link to issue number:

None, related to #4199, Originally reported on one of the Polish mailing lists (I cannot link to the conversation archives cannot be accessed for non subscribers)

Summary of the issue:

As described in #4199 when starting Office programs Word, Excel clipboard manager can sometimes steal accessibility focus making it impossible to interact with the document / spreadsheet.
Most cases were fixed but it seems one has been missed - focus lands on something called Collect and Paste 2.0 ,making interaction with the actual document difficult.

Description of how this pull request fixes the issue:

Since the "Collect and paste" has a custom eventObjectID SDM~has not been applied to it causing focus to be incorrect. This custom ID has been added to the list of objects for which SDM~applies.

Testing strategy:

Started Excel from the run box - made sure that focus lands on the actual spreadsheet whereas previously it didn't.

Known issues with pull request:

None known

Change log entries:

Bug fixes

  • Clipboard manager pane should no longer incorrectly steal focus when opening some Office programs

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner August 14, 2021 14:37
@lukaszgo1
Copy link
Contributor Author

cc @michaelDCurran

@lukaszgo1
Copy link
Contributor Author

@michaelDCurran Have you seen this? The person who reported this problem to me asked if it would be possible to get this bug fix into 2021.3 that's why I've decided to ping you again.

@lukaszgo1
Copy link
Contributor Author

lukaszgo1 commented Oct 1, 2021

@michaelDCurran Given the small size of this PR it would be a real pity not to get it into 2021.3. Is there anything which can be done on the author side (aside from pinging you from time to time and hoping you would look at the code) to avoid small fixes like this being stuck for several months?

@josephsl
Copy link
Collaborator

josephsl commented Oct 6, 2021

Hi,

Is this unique to this user or can others reproduce this? I cannot seem to reproduce this - when I run Excel from Run dialog, Excel opens to Home screen (this is on Excel 365).

@lukaszgo1
Copy link
Contributor Author

It is reproducible for both the user who reported this to me and on my machine (in my case on Win 7) in theirs on Win 10 20H2. I'm not sure what is different perhaps version of Office or specific things set in Excel's settings. At any rate even if this would be reproducible only for original reporter assuming this fix has no adverse side effects there is no reason not to merge it IMO.

@josephsl
Copy link
Collaborator

josephsl commented Oct 6, 2021 via email

@lukaszgo1
Copy link
Contributor Author

@josephsl I really really don't want to over engineer this. Two people confirmed that the problem exists and then two people confirmed that this fix works. Waiting for additional confirmations which as it so often happens when asking users for tests never comes can only results in additional delays. As it is this PR is very simple and awaits review for almost two months. If you have specific problems with this fix then I'm happy to discuss / implement it differently.

@josephsl
Copy link
Collaborator

josephsl commented Oct 6, 2021 via email

@britechguy
Copy link

britechguy commented Oct 6, 2021 via email

@lukaszgo1 lukaszgo1 changed the title Ensure that clipboard manager does not still focus when starting MS Office programs Ensure that clipboard manager does not steal focus when starting MS Office programs Oct 7, 2021
@CyrilleB79
Copy link
Collaborator

still -> steal
To be corrected also in initial description please ('summary' paragraph and overall 'Change log')

@lukaszgo1 lukaszgo1 force-pushed the MSOClipboardPaneDontStillFocus branch from 19a7a3f to 936b7d2 Compare October 7, 2021 18:51
@lukaszgo1
Copy link
Contributor Author

Given the small size of this PR and how early in the release cycle it has been submitted it is a real shame it didn't get into 2021.3 @michaelDCurran Can we at least have this added into 2022.1 so this is not forgotten once again?

@josephsl
Copy link
Collaborator

josephsl commented Oct 18, 2021 via email

@lukaszgo1
Copy link
Contributor Author

another option might be to target beta branch.

I don't think this fix is important enough to go to beta at this stage. My last comment was more of a "I don't think this PR has been handled well" thing rather than "This PR is important and should be in 2021.3".

@michaelDCurran michaelDCurran merged commit 7df7bf3 into nvaccess:master Oct 19, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Oct 19, 2021
@michaelDCurran michaelDCurran modified the milestones: 2021.3, 2022.1 Oct 19, 2021
@lukaszgo1 lukaszgo1 deleted the MSOClipboardPaneDontStillFocus branch October 19, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants