Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liblouis to 3.19.0 #12810

Merged
merged 4 commits into from Sep 19, 2021
Merged

Conversation

aaclause
Copy link
Contributor

@aaclause aaclause commented Sep 4, 2021

Link to issue number:

None

Summary of the issue:

Liblouis 3.19.0 has been released.

Description of how this pull request fixes the issue:

Updates liblouis to 3.19.0 which adds 3 new braille tables, fixes several bugs and cleans the codebase. Changelog.

Testing strategy:

Played with new braille tables and some others (input and output). Everything works as expected.

Known issues with pull request:

None

Change log entries:

Section: Changes

- Updated liblouis braille translator to [3.19.0 https://github.com/liblouis/liblouis/releases/tag/v3.19.0]. (#12810)
  - New braille tables: Russian grade 1, Tshivenda grade 1, Tshivenda grade 2

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@aaclause aaclause marked this pull request as ready for review September 5, 2021 19:06
@aaclause aaclause requested a review from a team as a code owner September 5, 2021 19:06
@lukaszgo1
Copy link
Contributor

It'd be great to include this PR into 2021.3 if possible.

@Futyn-Maker
Copy link

In this release the back translation in Russian uncontracted braille was added. Can you, please, remove input=False in 'ru-litbrl.ctb' and 'ru-litbrl-detailed.utb'? Now the only forward translation is relevant only for 'ru-ru-g1.ctb'.
Another thing is that in the change log you've mentioned 'Russian grade 2', but it's 'Russian grade 1'.
Thanks :)

@aaclause
Copy link
Contributor Author

aaclause commented Sep 6, 2021

In this release the back translation in Russian uncontracted braille was added. Can you, please, remove input=False in 'ru-litbrl.ctb' and 'ru-litbrl-detailed.utb'? Now the only forward translation is relevant only for 'ru-ru-g1.ctb'.

Thanks! I had forgotten about it.

Another thing is that in the change log you've mentioned 'Russian grade 2', but it's 'Russian grade 1'.
Thanks :)

Also done. But something is bugging me:
The display-name is "Russian contracted braille".
And the first line of the file is "liblouis: Russian literary (grade 1)"
Should this table be considered contracted (g2) or literary (g1)?
Thanks again!

@Futyn-Maker
Copy link

Should this table be considered contracted (g2) or literary (g1)?

It doesn't work like in English braille, for example. As the contracted braille isn't used in Russia oficially, we don't call literary braille "uncontracted" (a lot of people won't understand it). But the system of contracted braille was developed and now consists of two grades: grade 1 (partial contraction which includes syllables, prepositions, etc. and grade 2 which includes full words).
Thus, uncontracted braille may be called "grade 0", but such name isn't recommended.

@aaclause
Copy link
Contributor Author

aaclause commented Sep 6, 2021

@Futyn-Maker Thank for clarifying! Maybe should we add " (partial)" to the display-name (in NVDA)?

@Futyn-Maker
Copy link

@aaclause maybe later, if the grade 2 table will be made.

@codeofdusk
Copy link
Contributor

NVDA uses "grade 0" in English to refer to uncontracted German Braille. For consistency, I think "grade 0" is appropriate.

@Futyn-Maker
Copy link

Maybe this is acceptable for English names of these tables, but then these names shouldn't be translated on Russian like "нулевая ступень" (grade 0) as it can result in confusions for users.
Anyway, don't recommend change them at all.

@lukaszgo1
Copy link
Contributor

NVDA uses "grade 0" in English to refer to uncontracted German Braille. For consistency, I think "grade 0" is appropriate.

It does so only because German braille standard refers to uncontracted Braille as grade 0. Regardless of that I don't think consistency should be a factor here. When naming LibLouis tables we should remain as close to names used in LibLouis because we're not familiar with particular Braille codes being implemented, and since someone named these tables in a particular way they presumably did so in accordance with the local Braille jargon which in turn ensures that for users of these tables they can tell from the name what notation the given table implements.

@lukaszgo1
Copy link
Contributor

@michaelDCurran Are you planning to review this in time for 2021.3?

@AppVeyorBot
Copy link

See test results for failed build of commit be76e20d12

@michaelDCurran michaelDCurran merged commit 27d06f4 into nvaccess:master Sep 19, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants